[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9567babef30: Fix extraneous whitespace addition in line comments on clang-format directives (authored by penagos, committed by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

penagos added a comment. I don’t have commit rights; if someone could commit on my behalf that’d be great. - Luis Penagos - l...@penagos.co Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120188/new/ https://reviews.llvm.org/D120188

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Great! Thanks a lot! Do you have commit rights or you want someone to land it for you? For the latter, we'll need your name and email for the commit attribution. Repository: rG LLVM

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

penagos marked an inline comment as done. penagos added a comment. In D120188#674 , @HazardyKnusperkeks wrote: > Thanks for working on it. Happy to help! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

penagos marked 3 inline comments as done. penagos added inline comments. Comment at: clang/lib/Format/BreakableToken.cpp:818-822 const auto AllowsSpaceChange = -SpacesInPrefix != 0 || -(!NoSpaceBeforeFirstCommentChar() || -

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

penagos updated this revision to Diff 410115. penagos added a comment. - Split AllowsSpaceChange conditional over multiple variables to enhance readability. - Remove unnecessary column limit from unittest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

curdeius added inline comments. Comment at: clang/lib/Format/BreakableToken.cpp:818 const auto FirstNonSpace = Lines[i][IndentPrefix.size()]; const auto AllowsSpaceChange = +(!LineTok || !switchesFormatting(*LineTok)) && curdeius

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

HazardyKnusperkeks added a comment. Thanks for working on it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120188/new/ https://reviews.llvm.org/D120188 ___ cfe-commits mailing list

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/BreakableToken.cpp:818-822 const auto AllowsSpaceChange = -SpacesInPrefix != 0 || -(!NoSpaceBeforeFirstCommentChar() || - (FirstNonSpace == '}' &&

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

penagos created this revision. penagos requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120188 Files: clang/lib/Format/BreakableToken.cpp