This revision was automatically updated to reflect the committed changes.
Closed by commit rL245304: We shouldn't need to pass -fno-strict-aliasing when
building clang with clang. (authored by cbieneman).
Changed prior to commit:
http://reviews.llvm.org/D12036?vs=32349id=32420#toc
Repository:
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Sure I guess. I'm still not sure why we can't do this in the configure side of
things, but I don't really care that much for now.
http://reviews.llvm.org/D12036
Chris Bieneman be...@apple.com writes:
beanz updated this revision to Diff 32349.
beanz added a comment.
- Adapting to r245255 which exposes a variable in autoconf for which
compiler you are building with.
- Updated the CMake to be more CMake-y
Note: This has been tested by running a check
beanz updated this revision to Diff 32349.
beanz added a comment.
- Adapting to r245255 which exposes a variable in autoconf for which compiler
you are building with.
- Updated the CMake to be more CMake-y
Note: This has been tested by running a check on a stage2 clang built with asan
and
thakis added a subscriber: thakis.
Comment at: Makefile:68
@@ -67,3 +67,3 @@
# http://gcc.gnu.org/PR41874
# http://gcc.gnu.org/PR41838
#
The first of these is marked fixed, the second has a works on trunk comment
(from 2010). Maybe this isn't needed with
Chris Bieneman be...@apple.com writes:
beanz added a comment.
dblaikie,
I've run this through check-all with no issues.
Might want to bootstrap with sanitizers or something. Strict aliasing
related bugs can be subtle.
___
cfe-commits mailing list
beanz added a comment.
echristo,
I can move the makefile check to the autoconf check, but I think setting the
flags should stay in the clang CMakeLists/Makefile otherwise it will change
behavior. Today we only enable this flag for the clang subdirectory, not all of
LLVM.
Thoughts?
Ok… I wrote some CMake goop to enable sanitizers on a bootstrap build (I’ll
clean up the patches and send those out separately). check-clang worked with
asan and ubsan enabled.
Is that sufficient pre-commit testing?
I still need to rework the Makefile side of the patch to match Eric’s
Chris Bieneman be...@apple.com writes:
Ok… I wrote some CMake goop to enable sanitizers on a bootstrap build
(I’ll clean up the patches and send those out separately). check-clang
worked with asan and ubsan enabled.
Is that sufficient pre-commit testing?
Yes, I'd expect that to shake out any
