[PATCH] D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules

2022-03-07 Thread Orlando Cazalet-Hyams via Phabricator via cfe-commits
Orlando added a comment. In D120464#3363274 , @jansvoboda11 wrote: > In D120464#3363258 , @Orlando wrote: > >> Hi, the test `add-remove-irrelevant-module-map.m` starts failing with this >> commit on the

[PATCH] D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules

2022-03-07 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. In D120464#3363258 , @Orlando wrote: > Hi, the test `add-remove-irrelevant-module-map.m` starts failing with this > commit on the `llvm-clang-x86_64-sie-win` builder: >

[PATCH] D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules

2022-03-07 Thread Orlando Cazalet-Hyams via Phabricator via cfe-commits
Orlando added a comment. Hi, the test `add-remove-irrelevant-module-map.m` starts failing with this commit on the `llvm-clang-x86_64-sie-win` builder: https://lab.llvm.org/buildbot/#/builders/216/builds/929. Please can you take a look when you get the chance? Repository: rG LLVM Github

[PATCH] D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules

2022-03-07 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb45888e959ad: [clang][modules] Report module maps affecting `no_undeclared_includes` modules (authored by jansvoboda11). Repository: rG LLVM

[PATCH] D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules

2022-03-02 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added inline comments. Comment at: clang/test/Modules/add-remove-irrelevant-module-map.m:36-38 +#if __has_include("d.h") // This should use 'd.modulemap' in order to determine that 'd.h' + // doesn't exist for 'c' because of its

[PATCH] D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules

2022-03-01 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Herald added a project: All. LGTM, with one test suggestion. Comment at: clang/test/Modules/add-remove-irrelevant-module-map.m:36-38 +#if __has_include("d.h") //

[PATCH] D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules

2022-02-24 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 created this revision. jansvoboda11 added reviewers: ilyakuteev, Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since D106876 , PCM files don't report