This revision was automatically updated to reflect the committed changes.
Closed by commit rGd03e342803df: [clang-format] Fix assertion failure/crash
with… (authored by curdeius).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120902/new/
curdeius updated this revision to Diff 413380.
curdeius added a comment.
Safer condition.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120902/new/
https://reviews.llvm.org/D120902
Files:
clang/lib/Format/UnwrappedLineFormatter.cpp
owenpan added inline comments.
Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:313
break;
+ if ((*J)->Level == TheLine->Level)
+return false;
curdeius wrote:
> owenpan wrote:
> > To be safe?
> Good idea. Will do.
> Any
curdeius added inline comments.
Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:313
break;
+ if ((*J)->Level == TheLine->Level)
+return false;
owenpan wrote:
> To be safe?
Good idea. Will do.
Any idea how to provoke
owenpan added inline comments.
Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:313
break;
+ if ((*J)->Level == TheLine->Level)
+return false;
To be safe?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
curdeius created this revision.
curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan.
Herald added a project: All.
curdeius requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fixes
