[PATCH] D120989: Support debug info for alias variable

kavitha-natarajan added a subscriber: abrachet. kavitha-natarajan added a comment. Aliases are not supported on mac. Below commit has made the test to be skipped for mac. Thanks @abrachet for the quick fix. commit 50de659adcc19c4c197ba5e9a7719325af7151ee

[PATCH] D120989: Support debug info for alias variable

thakis added a comment. This breaks tests on mac: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8817534773179515649/+/u/package_clang/stdout?format=raw Script: -- : 'RUN: at line 1'; /opt/s/w/ir/cache/builder/src/third_party/llvm-bootstrap/bin/clang -cc1

[PATCH] D120989: Support debug info for alias variable

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1ea0191a420: [clang][DebugInfo] Support debug info for alias variable (authored by kavitha-natarajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120989: Support debug info for alias variable

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. In D120989#3411553 , @kavitha-natarajan wrote: >> Thanks for the details - can you ping this thread once the gdb thread has >> progressed/seems

[PATCH] D120989: Support debug info for alias variable

kavitha-natarajan added a comment. > Thanks for the details - can you ping this thread once the gdb thread has > progressed/seems like it's moving in this direction? @dblaikie, received comments for the gdb patch https://sourceware.org/pipermail/gdb-patches/2022-March/186960.html and the next

[PATCH] D120989: Support debug info for alias variable

kavitha-natarajan updated this revision to Diff 417878. kavitha-natarajan added a comment. @aprantl, thanks for your comments. Updated the patch with the fixes. @dblaikie, haven't got any response from gdb reviewers about the gdb patch yet. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D120989: Support debug info for alias variable

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3922 + return cast(GVE); +return dyn_cast_or_null(N); + } if we don't expect anything but non-null DINodes to be in the cache, then this whole condition should be ``` return

[PATCH] D120989: Support debug info for alias variable

kavitha-natarajan added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3921 + return cast(GVE); +return dyn_cast_or_null(N); + } aprantl wrote: > When would we enter a nullptr into the cache? In this change, only llvm::DIImportedEntity

[PATCH] D120989: Support debug info for alias variable

kavitha-natarajan updated this revision to Diff 414577. kavitha-natarajan added a comment. @aprantl Updated the comments following LLVM coding style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120989/new/ https://reviews.llvm.org/D120989

[PATCH] D120989: Support debug info for alias variable

aprantl added a comment. This looks mostly fine to me, I have a couple of superficial comments inline. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3914 + // imported declaration + auto IE = ImportedDeclCache.find(D->getCanonicalDecl()); Nit: The LLVM

[PATCH] D120989: Support debug info for alias variable

dblaikie added subscribers: JDevlieghere, aprantl. dblaikie added a comment. Maybe APple folks would want to move forward with this only when targeting lldb, though - which might unblock this patch. @aprantl @JDevlieghere ? What do you folks think? Repository: rG LLVM Github Monorepo

[PATCH] D120989: Support debug info for alias variable

dblaikie added a comment. In D120989#3362912 , @kavitha-natarajan wrote: > In D120989#3362491 , @dblaikie > wrote: > >> In D120989#3362490 , @dblaikie >> wrote: >> >>>

[PATCH] D120989: Support debug info for alias variable

kavitha-natarajan added a comment. In D120989#3362491 , @dblaikie wrote: > In D120989#3362490 , @dblaikie > wrote: > >> Broad question about debug info for aliases: How's this proposed solution >>

[PATCH] D120989: Support debug info for alias variable

kavitha-natarajan updated this revision to Diff 413347. kavitha-natarajan added a comment. Rebased and applied pre-merge check formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120989/new/ https://reviews.llvm.org/D120989 Files:

[PATCH] D120989: Support debug info for alias variable

dblaikie added a comment. In D120989#3362490 , @dblaikie wrote: > Broad question about debug info for aliases: How's this proposed solution > compare/contrast to GCC's behavior? Aaand, I see that was described in thhe patch description. Sorry for not

[PATCH] D120989: Support debug info for alias variable

dblaikie added a comment. Broad question about debug info for aliases: How's this proposed solution compare/contrast to GCC's behavior? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120989/new/ https://reviews.llvm.org/D120989

[PATCH] D120989: Support debug info for alias variable

dblaikie added a comment. I think it'd potentially go somewhere in `DWARFDebugLine::LineTable::getFileLineInfoForAddress` for instance - which could inspect the candidate row in the line table, and if it's line zero, it could go back one row in the table. This would avoid probing addresses

[PATCH] D120989: Support debug info for alias variable

kavitha-natarajan created this revision. kavitha-natarajan added reviewers: kamleshbhalui, umesh.kalappa0, probinson, dblaikie. kavitha-natarajan added a project: debug-info. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. kavitha-natarajan requested review of this