[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

RKSimon added a comment. In D121327#3383733 , @yln wrote: > New revision here: D121736 FYI - you could have continued to use this phab for review, it makes it easier to compare the changes you've made Repository:

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln added a comment. New revision here: D121736 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121327/new/ https://reviews.llvm.org/D121327 ___ cfe-commits mailing list

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln added a comment. Hi @Orlando and @RKSimon! Thanks for pointing out the test failure and reverting the change. I see this failure: : 'RUN: at line 1'; /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/opt -lower-global-dtors -S <

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

RKSimon added a comment. Herald added a subscriber: asb. @yln I've reverted your commit at rG7262eacd41997d7ca262d83367e28998662c1b21 to try and get the buildbots green again Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

Orlando added a comment. Hi @yln, the test you added `llvm/test/Transforms/LowerGlobalDestructors/lower-global-dtors.ll` is failing on some bots, e.g. https://lab.llvm.org/buildbot/#/builders/139/builds/18527 (builder `llvm-clang-x86_64-sie-ubuntu-fast`). Please can you take a look?

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yln marked an inline comment as done. Closed by commit rG9c542a5a4e1b: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO (authored by yln). Repository: rG

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln marked 2 inline comments as done. yln added inline comments. Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:900 + // __cxa_atexit calls to avoid emitting the deprecated __mod_term_func. + if (TM->getTargetTriple().isOSBinFormatMachO()) +

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

sunfish added a comment. In D121327#3381123 , @yln wrote: > @sunfish > Hi Dan, I hope you are still happy with this change. I didn't change any > WebAssembly tests, but rather added a new IR-level test, so all existing > WebAssembly behavior should

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln updated this revision to Diff 415282. yln added a comment. Report fatal error when we can, instead of never. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121327/new/ https://reviews.llvm.org/D121327 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

delcypher added inline comments. Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1181 +unsigned Priority, const MCSymbol *KeySym) const { + // TODO(yln): Remove -lower-global-dtors-via-cxa-atexit fallback flag + // (LowerGlobalDtorsViaCxaAtExit) and issue a

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln added a comment. @sunfish Hi Dan, I hope you are still happy with this change. I didn't change any WebAssembly tests, but rather added a new IR-level test, so all existing WebAssembly behavior should stay the same. Let me know if you have any concerns. Repository: rG LLVM Github

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln marked an inline comment as done. yln added inline comments. Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:900 + // __cxa_atexit calls to avoid emitting the deprecated __mod_term_func. + if (TM->getTargetTriple().isOSBinFormatMachO()) +

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln updated this revision to Diff 415273. yln added a comment. Herald added subscribers: cfe-commits, ormris. Herald added a project: clang. Add support for an escape hatch to fallback to the old behavior: via Clang driver flag (`-fregister-global-dtors-with-atexit`) or llc / code generation