[PATCH] D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page

This revision was automatically updated to reflect the committed changes. steakhal marked an inline comment as done. Closed by commit rG744e2a3e2232: [analyzer] ClangSA should tablegen doc urls refering to the main doc page (authored by steakhal). Changed prior to commit:

[PATCH] D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page

ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. Thanks! LGTM. Comment at: clang/utils/TableGen/ClangSACheckersEmitter.cpp:87-90 + std::string CheckerFullName = StringRef(getCheckerFullName(, "-")).lower(); + return

[PATCH] D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page

whisperity added a comment. (Side note: you should avoid the list-expansion syntax in URLs because browsers do not understand them and result in links that are not leading anywhere.) I like this. We should continue getting to the point where the documentation is having a uniform layout.

[PATCH] D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page

steakhal marked an inline comment as done. steakhal added a comment. Now it should be much smaller. Sorry for not doing this in the first place. Comment at: clang/utils/TableGen/ClangSACheckersEmitter.cpp:90-91 + + return

[PATCH] D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page

steakhal updated this revision to Diff 417344. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121387/new/ https://reviews.llvm.org/D121387 Files: clang/test/Analysis/diagnostics/Inputs/expected-sarif/sarif-multi-diagnostic-test.c.sarif clang/utils/TableGen/ClangSACheckersEmitter.cpp

[PATCH] D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page

martong added inline comments. Comment at: clang/utils/TableGen/ClangSACheckersEmitter.cpp:90-91 + + return (llvm::Twine("https://clang.llvm.org/docs/analyzer/checkers.html#;) + + CheckerFullName) .str(); > This patch will ensure that the doc

[PATCH] D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page

steakhal added a comment. I'd like to reach a wider consensus regarding this patch. @aaron.ballman @NoQ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121387/new/ https://reviews.llvm.org/D121387 ___ cfe-commits mailing list

[PATCH] D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page

steakhal updated this revision to Diff 415747. steakhal added a comment. Fix the single case when the `Sep` was not forwarded. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121387/new/ https://reviews.llvm.org/D121387 Files:

[PATCH] D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang/utils/TableGen/ClangSACheckersEmitter.cpp:27 -static std::string getPackageFullName(const Record *R); +static std::string

[PATCH] D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page

steakhal created this revision. steakhal added reviewers: aaron.ballman, NoQ, Szelethus, whisperity, martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. steakhal