[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0cceee755992: [clang] Produce a multiversion annotation in textual AST output. (authored by tahonermann). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

tahonermann added a comment. > I was surprised to see the Windows CI pass with that sed invocation! Ha! I didn't even think about that. I had copied the `RUN` lines from another test and only adjusted what was necessary. The bots must have Cygwin, MSYS[2], GnuWin32, or similar installed.

[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM (I was surprised to see the Windows CI pass with that `sed` invocation!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

tahonermann updated this revision to Diff 416668. tahonermann added a comment. Rebase to acquire fixes from parent commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121961/new/ https://reviews.llvm.org/D121961 Files:

[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

tahonermann updated this revision to Diff 416645. tahonermann added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121961/new/ https://reviews.llvm.org/D121961 Files: clang/lib/AST/TextNodeDumper.cpp

[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

tahonermann updated this revision to Diff 416618. tahonermann added a comment. Added a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121961/new/ https://reviews.llvm.org/D121961 Files: clang/lib/AST/TextNodeDumper.cpp

[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

tahonermann added a comment. > Is there a need for this functionality? Not a strong need, but I found it helpful in two scenarios: 1. A forward declaration of a multiversion function is not required to include a multiversion function attribute; later declarations might trigger

[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

erichkeane added a comment. In D121961#3391988 , @aaron.ballman wrote: > Is there a need for this functionality? The text node dumper already dumps > attributes associated with the function: https://godbolt.org/z/EbW8E74TT > > If the change is

[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

aaron.ballman added a comment. Is there a need for this functionality? The text node dumper already dumps attributes associated with the function: https://godbolt.org/z/EbW8E74TT If the change is necessary, it needs some test coverage (I'd recommend adding the test to the `clang/test/AST`

[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds a "multiversion" annotation to textual