zixuan-wu added inline comments.
Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:648
+#define CASE_CUDA_VERSION(CUDA_VER, PTX_VER)
\
+ case CudaVersion::CUDA_##CUDA_VER:
\
+PtxFeature = "+ptx"
jhuber6 added inline comments.
Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:648
+#define CASE_CUDA_VERSION(CUDA_VER, PTX_VER)
\
+ case CudaVersion::CUDA_##CUDA_VER:
\
+PtxFeature = "+ptx"
zixuan-wu added inline comments.
Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:648
+#define CASE_CUDA_VERSION(CUDA_VER, PTX_VER)
\
+ case CudaVersion::CUDA_##CUDA_VER:
\
+PtxFeature = "+ptx"
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa3248e4b28ce: [CUDA] Add getTargetFeatures for the NVPTX
toolchain (authored by jhuber6).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122089/new/
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122089/new/
https://reviews.llvm.org/D122089
jhuber6 added inline comments.
Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:635
+ const llvm::opt::ArgList ,
+ std::vector ,
+ Optional CudaVersion) {
jdoerfert added inline comments.
Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:635
+ const llvm::opt::ArgList ,
+ std::vector ,
+ Optional CudaVersion) {
Why
jhuber6 created this revision.
jhuber6 added reviewers: jdoerfert, tra, tianshilei1992, yaxunl.
Herald added a subscriber: asavonic.
Herald added a project: All.
jhuber6 requested review of this revision.
Herald added subscribers: cfe-commits, sstefan1.
Herald added a project: clang.
The NVPTX
