Re: [PATCH] D12209: [libcxx] Remove installation rules on Darwin when it would overwrite the system installation.

2015-08-25 Thread Jonathan Roelofs via cfe-commits
jroelofs accepted this revision. This revision is now accepted and ready to land. Comment at: CMakeLists.txt:105 @@ +104,3 @@ +if (${CMAKE_SYSTEM_NAME} MATCHES Darwin AND NOT LIBCXX_OVERRIDE_DARWIN_INSTALL) + if (${CMAKE_INSTALL_PREFIX} STREQUAL /usr) +message(WARNING

Re: [PATCH] D12209: [libcxx] Remove installation rules on Darwin when it would overwrite the system installation.

2015-08-20 Thread Jonathan Roelofs via cfe-commits
jroelofs added a comment. I like it! http://reviews.llvm.org/D12209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D12209: [libcxx] Remove installation rules on Darwin when it would overwrite the system installation.

2015-08-20 Thread Eric Fiselier via cfe-commits
EricWF created this revision. EricWF added reviewers: mclow.lists, beanz, jroelofs. EricWF added a subscriber: cfe-commits. On Mac OS X overwriting `/usr/lib/libc++.dylib` can cause your computer to fail to boot. This patch tries to make it harder to do that accidentally. If