[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuw marked an inline comment as done. zixuw added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:159 + switch (Language) { + case Language::C: +return "c"; zixuw wrote: > zixuan-wu wrote: > > It's same name as

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:159 + switch (Language) { + case Language::C: +return "c"; zixuan-wu wrote: > It's same name as `Language` variable above, and it cause compile error. >

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuan-wu added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:159 + switch (Language) { + case Language::C: +return "c"; It's same name as `Language` variable above, and it cause compile error. @zixuw Maybe the

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

This revision was automatically updated to reflect the committed changes. Closed by commit rG89f6b26f1beb: [clang][extract-api] Refactor ExtractAPI and improve docs (authored by zixuw). Changed prior to commit: https://reviews.llvm.org/D122160?vs=417365=417383#toc Repository: rG LLVM Github

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

dang accepted this revision. dang added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122160/new/ https://reviews.llvm.org/D122160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuw updated this revision to Diff 417365. zixuw added a comment. Address review issue: remove unnecessary `copyString` overload Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122160/new/ https://reviews.llvm.org/D122160 Files:

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuw updated this revision to Diff 417361. zixuw marked 3 inline comments as done. zixuw added a comment. Address review issues: - Documenting the responsibility of keeping StringRefs alive for APISet - Remove unnecessary `static` for helper functions in an anonymous namespace Repository:

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM once the last few bits of feedback I left are considered. Comment at: clang/include/clang/ExtractAPI/API.h:139 + /// Create and add a global variable record into the API

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuw updated this revision to Diff 417145. zixuw added a comment. - Minor Doxygen auto-link string adjustments - Forgot to rename the test directory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122160/new/ https://reviews.llvm.org/D122160

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuw added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:123 +private: + virtual void anchor(); }; dang wrote: > This is new so I don't think it belongs in this patch. > This is to follow the LLVM Coding Standards guideline of providing

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuw updated this revision to Diff 417132. zixuw marked 11 inline comments as done. zixuw added a comment. Address review issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122160/new/ https://reviews.llvm.org/D122160 Files:

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuw added a comment. In D122160#3397366 , @tschuett wrote: > Would you mind putting a high level description of the intent at the top of > the main header. > > Maybe even a link at https://github.com/apple/swift-docc-symbolkit Sure thing!

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

tschuett added a comment. Would you mind putting a high level description of the intent at the top of the main header. Maybe even a link at https://github.com/apple/swift-docc-symbolkit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122160/new/

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:34 +/// Documentation comment is a vector of RawComment::CommentLine. +/// You should use the actual name of the type or "This" Comment at:

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuw created this revision. Herald added a subscriber: mgorny. Herald added a reviewer: dang. Herald added a project: All. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - The name SymbolGraph is inappropriate and confusing for the