[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

wolfgangp added a comment. Seems to be fine now. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 ___ cfe-commits mailing list

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae added a comment. Created new patch to fix the test fail at https://reviews.llvm.org/D123887 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 ___

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

beanz added a comment. @wolfgangp I can't reproduce the failure locally, but I have a guess what's going wrong. I _think_ the issue is that the SmallStrings aren't null terminated and the cleared allocations aren't zero'd. I pushed a speculative fix in rG329abac134a3

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

wolfgangp added a comment. Hi, there seems to be a unit test failure, for example here . /home/buildbot/as-worker-91/clang-with-lto-ubuntu/build/stage1/tools/clang/unittests/Driver/./ClangDriverTests

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG721651be246e: [HLSL][clang][Driver] Support target profile command line option. (authored by python3kgae, committed by beanz). Changed prior to

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 ___

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 422677. python3kgae added a comment. Code cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 422377. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Driver.h

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 422365. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Driver.h

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

beanz added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1196 + + if (IsDXCMode()) { +// clang-dxc target is build from target_profile option. nit: this can be an `else` for the `if` above Comment at:

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 422350. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Driver.h

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 422272. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Driver.h

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 422128. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Driver.h

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

beanz added inline comments. Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:43 +return false; + if (!Version.getMinor()) +return false; python3kgae wrote: > beanz wrote: > > Do we need to verify this or can we just assume if there is no minor > >

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae added inline comments. Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:43 +return false; + if (!Version.getMinor()) +return false; beanz wrote: > Do we need to verify this or can we just assume if there is no minor version > specified that

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

beanz added reviewers: pow2clk, rnk, bogner, MaskRay, dexonsmith. beanz added a comment. Herald added a subscriber: StephenFan. Looping in a few extra reviewers, also added some comments below. Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:43 +return false; + if

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 419991. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Driver.h

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 419954. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Driver.h

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 419893. python3kgae added a comment. Herald added a subscriber: ormris. Change lit test to unit test to avoid require build DirectX target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae created this revision. python3kgae added reviewers: beanz, steven_wu, JonChesterfield. python3kgae added a project: clang. Herald added a subscriber: mgorny. Herald added a reviewer: sscalpone. Herald added a project: All. python3kgae requested review of this revision. Herald added