Re: [PATCH] D12381: [Static Analyzer] Merge the Objective-C Generics Checker into Dynamic Type Propagation checker.

2015-09-13 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247532: [Static Analyzer] Merge the Objective-C Generics Checker into Dynamic Type… (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D12381?vs=34606=34651#toc Repository: rL

Re: [PATCH] D12381: [Static Analyzer] Merge the Objective-C Generics Checker into Dynamic Type Propagation checker.

2015-09-10 Thread Gábor Horváth via cfe-commits
xazax.hun added a comment. In http://reviews.llvm.org/D12381#241709, @xazax.hun wrote: > There are several fallouts from this review, so I decided to split this patch > up the following way: > > 1. I created a patch to incorporate the result of this review into > ObjCGenericsChecker:

Re: [PATCH] D12381: [Static Analyzer] Merge the Objective-C Generics Checker into Dynamic Type Propagation checker.

2015-09-08 Thread Gábor Horváth via cfe-commits
xazax.hun marked 2 inline comments as done. xazax.hun added a comment. There are several fallouts from this review, so I decided to split this patch up the following way: 1. I created a patch to incorporate the result of this review into ObjCGenericsChecker: http://reviews.llvm.org/D12701 2. I

Re: [PATCH] D12381: [Static Analyzer] Merge the Objective-C Generics Checker into Dynamic Type Propagation checker.

2015-09-01 Thread Gábor Horváth via cfe-commits
xazax.hun marked an inline comment as not done. Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:81 @@ +80,3 @@ +initBugType(); +SmallString<64> Buf; +llvm::raw_svector_ostream OS(Buf); zaks.anna wrote: > How do we know that the

Re: [PATCH] D12381: [Static Analyzer] Merge the Objective-C Generics Checker into Dynamic Type Propagation checker.

2015-08-27 Thread Anna Zaks via cfe-commits
zaks.anna added a comment. Partial review in-line. Comment at: lib/StaticAnalyzer/Checkers/Checkers.td:456 @@ -455,2 +455,3 @@ def ObjCGenericsChecker : CheckerObjCGenerics, HelpTextCheck for incorrect usages of parameterized types., + DescFileDynamicTypePropagation.cpp;

[PATCH] D12381: [Static Analyzer] Merge the Objective-C Generics Checker into Dynamic Type Propagation checker.

2015-08-26 Thread Gábor Horváth via cfe-commits
xazax.hun created this revision. xazax.hun added reviewers: krememek, zaks.anna, jordan_rose, dcoughlin. xazax.hun added a subscriber: cfe-commits. This patch merged the functionality from ObjCGenericsChecker into DynamicTypePropagation checker. Note that the Generics Checker can still be turned