This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb09ba4262076: Bug 51277: [DWARF] DW_AT_alignment incorrect
when (authored by MaggieYi).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
MaggieYi added inline comments.
Comment at: clang/test/CodeGenCXX/debug-info-struct-align.cpp:11
+} __attribute__((aligned(1)));
+struct MyType mt;
+
dblaikie wrote:
> You can drop the "struct" here and from other references to these types (in
> mt1/mt2 and the
MaggieYi updated this revision to Diff 424420.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124006/new/
https://reviews.llvm.org/D124006
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/test/CodeGenCXX/debug-info-struct-align.cpp
Index:
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks good, thanks!
Comment at: clang/test/CodeGenCXX/debug-info-struct-align.cpp:11
+} __attribute__((aligned(1)));
+struct MyType mt;
+
You can drop
MaggieYi updated this revision to Diff 424257.
MaggieYi added a comment.
Thanks David, I have modified the test following your advice.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124006/new/
https://reviews.llvm.org/D124006
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
dblaikie added a comment.
Could you include some static_asserts(+alignof) in the test case to demonstrate
these are the alignments that the language is computing too?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124006/new/
MaggieYi created this revision.
MaggieYi added reviewers: echristo, jmorse, wolfgangp, probinson, dblaikie,
aprantl.
Herald added a project: All.
MaggieYi requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The detailed description of the
