[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

erichkeane added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:13165 +// when checking satisfaction. +NewTrailingRequiresClause = getDerived().TransformExpr(TRC); + So I just noticed this: What happens when

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

cor3ntin added a comment. @erichkeane @aaron.ballman Thanks! I'll keep an eye out for further issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124012/new/ https://reviews.llvm.org/D124012 ___

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG69dd89fdcbd8: [Clang] Fix references to captured variables in dependant context. (authored by cor3ntin). Repository: rG LLVM Github Monorepo

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

erichkeane added a comment. In D124012#3461781 , @cor3ntin wrote: > @erichkeane I will land that later today to unstuck people relying on main, > let me know if you still want to have a look I didn't see anything on a quick pass, so LGTM! Repository:

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

cor3ntin added a comment. @erichkeane I will land that later today to unstuck people relying on main, let me know if you still want to have a look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124012/new/ https://reviews.llvm.org/D124012

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please wait a bit before landing so other reviewers have time to weigh in (should be fine to land tomorrow sometime if you don't hear back). Comment

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

cor3ntin updated this revision to Diff 423675. cor3ntin marked an inline comment as done. cor3ntin added a comment. Remove `startLambdaDefinition` which is no longer used Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124012/new/

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

cor3ntin marked an inline comment as done. cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:539-546 void Sema::buildLambdaScope(LambdaScopeInfo *LSI, CXXMethodDecl *CallOperator, SourceRange IntroducerRange,

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1378-1383 + CompleteLambdaCallOperator( + Method, Intro.Range.getBegin(), ParamInfo.getTrailingRequiresClause(), + MethodTyInfo, ParamInfo.getDeclSpec().getConstexprSpecifier(), Params, +

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

cor3ntin updated this revision to Diff 423671. cor3ntin added a comment. - Get rid of buildLambdaScopeCaptures - Set the call operator inner loc in CompleteLambdaCallOperator (+ tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124012/new/

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:539-546 void Sema::buildLambdaScope(LambdaScopeInfo *LSI, CXXMethodDecl *CallOperator, SourceRange IntroducerRange, LambdaCaptureDefault

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

cor3ntin updated this revision to Diff 423657. cor3ntin added a comment. More cleanups and formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124012/new/ https://reviews.llvm.org/D124012 Files: clang/include/clang/Sema/Sema.h

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

cor3ntin updated this revision to Diff 423656. cor3ntin added a comment. Fix whitespace changes (again) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124012/new/ https://reviews.llvm.org/D124012 Files: clang/include/clang/Sema/Sema.h

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

cor3ntin updated this revision to Diff 423653. cor3ntin added a comment. Remove some whitespace only changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124012/new/ https://reviews.llvm.org/D124012 Files: clang/include/clang/Sema/Sema.h

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D119136 changed how captures are handled in a lambda call operator declaration, but