kevcadieux added a comment.
@sstwcw @HazardyKnusperkeks : this change introduced a regression in one of the
clang format unit tests. I fixed it in the revision below. Could anyone please
take a look / approve this revision to unblock Windows debug builds? Thanks!
This revision was automatically updated to reflect the committed changes.
Closed by commit rG370bee480139: [clang-format] Fix whitespace counting stuff
(authored by sstwcw).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124748/new/
HazardyKnusperkeks accepted this revision.
HazardyKnusperkeks added a comment.
This revision is now accepted and ready to land.
Can there be a test case, not related to Verilog? Or do we need to wait until
you pump up the support for that?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
sstwcw updated this revision to Diff 433626.
sstwcw added a comment.
- add comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124748/new/
https://reviews.llvm.org/D124748
Files:
clang/lib/Format/FormatTokenLexer.cpp
HazardyKnusperkeks added inline comments.
Comment at: clang/lib/Format/FormatTokenLexer.cpp:839
+void FormatTokenLexer::resizeToken(size_t NewLen) {
+ resetLexer(SourceMgr.getFileOffset(Lex->getSourceLocation(
sstwcw wrote:
> HazardyKnusperkeks wrote:
> > Can
sstwcw marked 8 inline comments as done.
sstwcw added a comment.
This patch is not NFC. But there would not be change in behavior if the
input is valid C as far as I know.
input:
#define LIST \
`ENTRY \
`ENTRY
output before, note extra line:
#define LIST
sstwcw updated this revision to Diff 429530.
sstwcw added a comment.
- address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124748/new/
https://reviews.llvm.org/D124748
Files:
clang/lib/Format/FormatTokenLexer.cpp
MyDeveloperDay added a comment.
Is there any way you could add a unit test for this?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124748/new/
https://reviews.llvm.org/D124748
___
cfe-commits mailing
owenpan added a comment.
Is this patch NFC?
Comment at: clang/lib/Format/FormatTokenLexer.cpp:859-867
+switch (Cur[0]) {
+case '\n':
+case '\r':
+case '\f':
+case '\v':
+case ' ':
+case '\t':
I'd replace the `switch` with `if
HazardyKnusperkeks added inline comments.
Comment at: clang/lib/Format/FormatTokenLexer.cpp:839
+void FormatTokenLexer::resizeToken(size_t NewLen) {
+ resetLexer(SourceMgr.getFileOffset(Lex->getSourceLocation(
Can you add some documentation?
sstwcw created this revision.
sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan.
Herald added a project: All.
sstwcw requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The current way of counting whitespace would
11 matches
Mail list logo
