djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good. Do you have commit access?
http://reviews.llvm.org/D12489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ksuther added a comment.
Adding another comment in hopes of getting some visibility on this. Do I need
to add other people as reviewers?
http://reviews.llvm.org/D12489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
klimek added a comment.
In the future, please add cfe-commits as subscriber on the initial post,
otherwise the initial email will not go to the mailing list. Thx!
http://reviews.llvm.org/D12489
___
cfe-commits mailing list
klimek added a comment.
Oh, and you'll want to add tests :) unittests/Format/FormatTest.cpp
http://reviews.llvm.org/D12489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ksuther updated this revision to Diff 33947.
ksuther added a comment.
Added two tests: One of a for/in loop with a cast, and one without.
http://reviews.llvm.org/D12489
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
ksuther added a reviewer: djasper.
ksuther added a comment.
This is my first commit and I'm trying to figure out the system, hope I'm doing
this right.
http://reviews.llvm.org/D12489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
