This revision was automatically updated to reflect the committed changes.
Closed by commit rGdca37af061fb: [NFC][Clang] Modify expect of fail test or
XFAIL because CSKY align is different (authored by zixuan-wu).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124977/new/
https://reviews.llvm.org/D124977
___
cfe-commits mailing
zixuan-wu added a comment.
Gentle pin..
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124977/new/
https://reviews.llvm.org/D124977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
zixuan-wu updated this revision to Diff 428585.
zixuan-wu added a comment.
Address comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124977/new/
https://reviews.llvm.org/D124977
Files:
clang/test/CodeGen/c-strings.c
clang/test/Sema/builtin-alloca-with-align.c
Index:
zixuan-wu added inline comments.
Comment at: clang/test/Sema/builtin-alloca-with-align.c:32
void test8(void) {
+#if defined(__csky__)
__builtin_alloca_with_align(sizeof(__INT64_TYPE__),
__alignof__(__INT64_TYPE__)); // expected-warning {{second argument to
aaron.ballman added inline comments.
Comment at: clang/test/Sema/builtin-alloca-with-align.c:32
void test8(void) {
+#if defined(__csky__)
__builtin_alloca_with_align(sizeof(__INT64_TYPE__),
__alignof__(__INT64_TYPE__)); // expected-warning {{second argument to
zixuan-wu added a comment.
Could anybody else have a review or nominate a reviewer?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124977/new/
https://reviews.llvm.org/D124977
___
cfe-commits mailing
rengolin added inline comments.
Comment at: clang/test/Sema/builtin-alloca-with-align.c:32
void test8(void) {
+#if defined(__csky__)
__builtin_alloca_with_align(sizeof(__INT64_TYPE__),
__alignof__(__INT64_TYPE__)); // expected-warning {{second argument to
zixuan-wu added inline comments.
Comment at: clang/test/Sema/builtin-alloca-with-align.c:32
void test8(void) {
+#if defined(__csky__)
__builtin_alloca_with_align(sizeof(__INT64_TYPE__),
__alignof__(__INT64_TYPE__)); // expected-warning {{second argument to
rengolin added inline comments.
Comment at: clang/test/Sema/builtin-alloca-with-align.c:32
void test8(void) {
+#if defined(__csky__)
__builtin_alloca_with_align(sizeof(__INT64_TYPE__),
__alignof__(__INT64_TYPE__)); // expected-warning {{second argument to
zixuan-wu created this revision.
zixuan-wu added reviewers: majnemer, kparzysz, ddunbar.
Herald added a project: All.
zixuan-wu requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
CSKY is always in 4-byte align, no matter it's long long type.
11 matches
Mail list logo