[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang updated this revision to Diff 505720. tingwang added a comment. As verifier change and baseline test cases have been moved into https://reviews.llvm.org/D145767, update this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125095/new/

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang updated this revision to Diff 504031. tingwang added a comment. Herald added a subscriber: hiraditya. Rebase and update patch (1) Update verifier check on associated metadata to allow multiple operands for AIX. (2) Update test cases to use opaque pointer. Repository: rG LLVM Github

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang added a comment. Currently this patch does not work due to limit set on associated metadata operand count (forced to be single operand). commit 87f2e9448e82bbed4ac59bb61bea03256aa5f4de Author: Matt Arsenault Date: Mon Jan 9 12:17:38 2023 -0500 Verifier: Add checks for

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang updated this revision to Diff 443201. tingwang added a comment. Add guards against TLS variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125095/new/ https://reviews.llvm.org/D125095 Files: clang/lib/CodeGen/CGDecl.cpp

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang updated this revision to Diff 442773. tingwang added a comment. Drop TLS related .ref for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125095/new/ https://reviews.llvm.org/D125095 Files: clang/lib/CodeGen/CGDecl.cpp

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang updated this revision to Diff 442419. tingwang added a comment. Update according to comments: (1) Merged cleanupAssoc() into genAssocMeta(), and renamed genAssocMeta() to EmitAssociatedMetadata(). (2) Removed "-debug-info-kind=limited" from all test cases. Repository: rG LLVM Github

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:522 EmitCXXThreadLocalInitFunc(); + if (getTriple().isOSAIX()) { +genAssocMeta(); shchenz wrote: > Seems this dos not follow other functions call's style. Can we call a >

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

shchenz added a comment. Sorry, I am really not familiar with these FE stuffs. Need approval from other reviewers who know more about this part. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:522 EmitCXXThreadLocalInitFunc(); + if (getTriple().isOSAIX()) { +

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang added a comment. Gentle ping. Verified the patch works with latest code base, all tests green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125095/new/ https://reviews.llvm.org/D125095 ___

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang updated this revision to Diff 435107. tingwang added a comment. Herald added subscribers: llvm-commits, jdoerfert. Update according to comments: (1) Update docs (2) Use `addVarTermAssoc` (3) Remove redundant call to `updateAssociatedFunc(FFDtorTermAssoc...` (4) Remove unnecessary

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang marked an inline comment as done. tingwang added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:688 +updateAssociatedFunc(VFInitTermAssoc, LocalCXXGlobalInits, GetElem, Fn); +updateAssociatedFunc(FFDtorTermAssoc, LocalCXXGlobalInits,

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang added a comment. In D125095#3552451 , @shchenz wrote: > Thanks for doing this. I am not familiar with the frontend, so I may be > wrong/stupid in the follow comments : ) > Hope other experts like @hubert.reinterpretcast can give more meaningful

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

shchenz added a comment. Thanks for doing this. I am not familiar with the frontend, so I may be wrong/stupid in the follow comments : ) Hope other experts like @hubert.reinterpretcast can give more meaningful comments. I tested on AIX, seems for static variable `static int x = foo();` in

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125095/new/ https://reviews.llvm.org/D125095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang updated this revision to Diff 428268. tingwang added a comment. Update the three test cases introduced in this patch to use opaque-pointer clang/test/CodeGen/PowerPC/aix-init-ref-null.cpp clang/test/CodeGen/PowerPC/aix-ref-static-var.cpp clang/test/CodeGen/PowerPC/aix-ref-tls_init.cpp

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang created this revision. tingwang added reviewers: jsji, nemanjai, shchenz, hubert.reinterpretcast, PowerPC. tingwang added projects: LLVM, clang. Herald added a project: All. tingwang requested review of this revision. Herald added a subscriber: cfe-commits. This is the frontend part of