[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

kees marked an inline comment as done. kees added a comment. In D125142#3825972 , @MaskRay wrote: >> [clang][auto-init] Remove -enable flag for "zero" mode > > The subject should be updated to mention the exact option name, not a vague > `-enable` and

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

MaskRay added a comment. > [clang][auto-init] Remove -enable flag for "zero" mode The subject should be updated to mention the exact option name, not a vague `-enable` and `"zero" mode` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125142/new/

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:240-243 +- -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang + has been deprecated. The flag will be removed in Clang 17. + -ftrivial-auto-var-init=zero is now available

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

kees added a comment. Thanks for all the careful consideration; I appreciate it! I'll land this tomorrow unless there are new specific objections. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125142/new/ https://reviews.llvm.org/D125142

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

aaron.ballman added a comment. In D125142#3782296 , @xbolva00 wrote: > In D125142#3782244 , > @nickdesaulniers wrote: > >> @rsmith can we get some guidance here? Has your opinion changed in the time >> since

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

xbolva00 added a comment. In D125142#3782244 , @nickdesaulniers wrote: > @rsmith can we get some guidance here? Has your opinion changed in the time > since GCC has been shipping this? Maybe we should now ask @aaron.ballman as he is now main code

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

nickdesaulniers added a comment. @rsmith can we get some guidance here? Has your opinion changed in the time since GCC has been shipping this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125142/new/ https://reviews.llvm.org/D125142

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

xbolva00 added a comment. In D125142#3505767 , @jfb wrote: > I think the most relevant post from @rsmith is: > https://discourse.llvm.org/t/making-ftrivial-auto-var-init-zero-a-first-class-option/55143/40 > > He has a prototype:

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

kees added a comment. In D125142#3505767 , @jfb wrote: > I think the most relevant post from @rsmith is: > https://discourse.llvm.org/t/making-ftrivial-auto-var-init-zero-a-first-class-option/55143/40 > > He has a prototype:

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

jfb added a subscriber: Florian. jfb added a comment. I think the most relevant post from @rsmith is: https://discourse.llvm.org/t/making-ftrivial-auto-var-init-zero-a-first-class-option/55143/40 He has a prototype: https://reviews.llvm.org/D79249 I assume he would like someone to pursue it

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

kees added a comment. This is marked "needs revision", but I think it just needs wider review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125142/new/ https://reviews.llvm.org/D125142 ___ cfe-commits

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

kees added a comment. In D125142#3502732 , @MaskRay wrote: > This cannot be committed as is. In particular, @rsmith's "We do not want to > create or encourage the creation of language dialects and non-portable code," > concern on >

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

aaron.ballman added a comment. In D125142#3502732 , @MaskRay wrote: > This cannot be committed as is. In particular, @rsmith's "We do not want to > create or encourage the creation of language dialects and non-portable code," > concern on >

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

MaskRay added a comment. This cannot be committed as is. In particular, @rsmith's "We do not want to create or encourage the creation of language dialects and non-portable code," concern on https://discourse.llvm.org/t/making-ftrivial-auto-var-init-zero-a-first-class-option/55143/2 (shared by

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

kees updated this revision to Diff 428224. kees edited the summary of this revision. kees added a comment. add release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125142/new/ https://reviews.llvm.org/D125142 Files:

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

nickdesaulniers accepted this revision. nickdesaulniers added a comment. Worth mentioning the deprecation plans in `clang/docs/ReleaseNotes.rst` and updaing the commit message+description on phab? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

kees updated this revision to Diff 428173. kees added a comment. This revision is now accepted and ready to land. update with suggestions - Add FIXME comment with deprecation schedule - Report deprecation warning when -enable flag is used Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. It looks like clang still produces meaningful diagnostics from `-Wuninitialized` and `-Wsometimes-uninitialized` even with `-ftrivial-auto-var-init=zero`. Same for

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

aaron.ballman added a comment. Also, you should definitely add some release notes for this change. Comment at: clang/include/clang/Driver/Options.td:2700-2701 MarshallingInfoEnum, "Uninitialized">; def enable_trivial_var_init_zero : Flag<["-"],

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

kees updated this revision to Diff 427916. kees added a comment. Report flag as "unused" Adjust flags and tests to have the option warn about being unused now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125142/new/

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

kees planned changes to this revision. kees added a comment. In D125142#3499010 , @brooks wrote: > It would be somewhat helpful as a transition aid if > `-enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang` > remained as a no-op

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

brooks added a comment. It would be somewhat helpful as a transition aid if `-enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang` remained as a no-op producing a warning (a generic unused argument warning would be fine). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

xbolva00 added a comment. Strong +1. It would be great to backport it to llvm 14.0.x as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125142/new/ https://reviews.llvm.org/D125142 ___ cfe-commits