This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG91ed7e194181: [clang] Allow all string types for all
attribute(format) styles (authored by fcloutier).
Changed prior to commit:
ahatanak accepted this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.
LGTM with one minor comment.
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3864
- if (Kind == CFStringFormat) {
-if (!isCFStringType(Ty, S.Context)) {
-
fcloutier created this revision.
fcloutier added reviewers: NoQ, ahatanak, aaron.ballman.
Herald added a project: All.
fcloutier requested review of this revision.
Herald added a project: clang.
It's not unusual to see functions like this:
void log(const char *fmt, ...) {
va_list ap;
