[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

steakhal added a comment. Conflict markers fixed by 6ccc2733e72017999a94c10147a71ff595286080 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125340/new/

[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d637956b792: [clang][NFC][AST] rename the ImportError to ASTImportError (authored by phyBrackets). Changed prior to commit: https://reviews.llvm.org/D125340?vs=428508=436881#toc Repository: rG LLVM

[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

balazske added a comment. LLDB should be at least compilable after the change. If it has an internal `ImportError` we must not change it. If it uses the renamed class we should rename it, or make an "using" alias and no rename (but not this is the best solution). Repository: rG LLVM Github

[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Yeah, okay, this patch makes sense now that I've seen a clash with python's ImportError . I've checked lldb c++ files and `ImportError`

[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

phyBrackets added a comment. In D125340#3506210 , @balazske wrote: > I found one other place in **LibASTImporter.rst** where `ImportError` is > used. LLDB should be checked too. Yeah , I update the file **LibASTImporter.rst**, I'm not sure if there is

[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

balazske added a comment. I found one other place in **LibASTImporter.rst** where `ImportError` is used. LLDB should be checked too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125340/new/ https://reviews.llvm.org/D125340

[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

balazske added a comment. Initially the `ImportError` was very related to `ASTImporter` but now the class is used at other less related places and files. `ImportError` is a too generic name for this unless it can be used at any other "import" in clang which is not the case (the class can be

[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

phyBrackets added a comment. In D125340#3505723 , @martong wrote: > What are the benefits of this renaming? I mean is there a name clash? Do we > have another kind of "import" in Clang or in some of the dependent projects, > don't we? AS it suggested

[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

martong added a comment. What are the benefits of this renaming? I mean is there a name clash? Do we have another kind of "import" in Clang or in some of the dependent projects, don't we? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125340/new/

[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

phyBrackets created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. phyBrackets requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. this patch