[PATCH] D125395: [analyzer][solver] Handle UnarySymExpr in RangeConstraintSolver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88abc50398eb: [analyzer][solver] Handle UnarySymExpr in RangeConstraintSolver (authored by martong). Changed prior to commit:

[PATCH] D125395: [analyzer][solver] Handle UnarySymExpr in RangeConstraintSolver

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125395/new/ https://reviews.llvm.org/D125395

[PATCH] D125395: [analyzer][solver] Handle UnarySymExpr in RangeConstraintSolver

martong updated this revision to Diff 429208. martong added a comment. - Add a test case for casts related crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125395/new/ https://reviews.llvm.org/D125395 Files:

[PATCH] D125395: [analyzer][solver] Handle UnarySymExpr in RangeConstraintSolver

martong updated this revision to Diff 428932. martong marked 6 inline comments as done. martong added a comment. - Address steakhal review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125395/new/ https://reviews.llvm.org/D125395 Files:

[PATCH] D125395: [analyzer][solver] Handle UnarySymExpr in RangeConstraintSolver

martong marked 13 inline comments as done. martong added a comment. In D125395#3506854 , @steakhal wrote: > Great content! > I've got a long list of nits though. Nothing personal :D No worries, thank you for being assiduous. Comment

[PATCH] D125395: [analyzer][solver] Handle UnarySymExpr in RangeConstraintSolver

steakhal added a comment. Great content! I've got a long list of nits though. Nothing personal :D Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1453 +const RangeSet *NegatedRange = nullptr; +if (const UnarySymExpr *USE = dyn_cast(Sym)) { +

[PATCH] D125395: [analyzer][solver] Handle UnarySymExpr in RangeConstraintSolver

martong added a comment. Fixes https://github.com/llvm/llvm-project/issues/55241 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125395/new/ https://reviews.llvm.org/D125395 ___ cfe-commits mailing list

[PATCH] D125395: [analyzer][solver] Handle UnarySymExpr in RangeConstraintSolver

martong updated this revision to Diff 428683. martong added a comment. - Add false positive test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125395/new/ https://reviews.llvm.org/D125395 Files:

[PATCH] D125395: [analyzer][solver] Handle UnarySymExpr in RangeConstraintSolver

martong created this revision. martong added reviewers: steakhal, NoQ. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a