[PATCH] D125871: [analyzer] Delete alpha.deadcode.UnreachableCode checker

2022-05-18 Thread Gabor Marton via Phabricator via cfe-commits
martong marked an inline comment as done. martong added a comment. In D125871#3521967 , @steakhal wrote: > Could you please give a few examples of these FPs for the record? Out of thin air I could come up with the following one below. Seems like `try`

[PATCH] D125871: [analyzer] Delete alpha.deadcode.UnreachableCode checker

2022-05-18 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. Could you please give a few examples of these FPs for the record? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125871/new/ https://reviews.llvm.org/D125871 ___ cfe-commits

[PATCH] D125871: [analyzer] Delete alpha.deadcode.UnreachableCode checker

2022-05-18 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/UnreachableCodeChecker.cpp:53-54 - - if (Eng.hasWorkRemaining()) -return; - I thought this check guards this checker to be meaningful. @martong Repository: rG LLVM Github

[PATCH] D125871: [analyzer] Delete alpha.deadcode.UnreachableCode checker

2022-05-18 Thread Gabor Marton via Phabricator via cfe-commits
martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:847 -let ParentPackage = DeadCodeAlpha in { - TODO, update the ReleseNotes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125871: [analyzer] Delete alpha.deadcode.UnreachableCode checker

2022-05-18 Thread Gabor Marton via Phabricator via cfe-commits
martong created this revision. martong added reviewers: NoQ, steakhal, Szelethus. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, mgorny. Herald added a project: All. martong requested