This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG93b4a41b5510: [RISCV] Add vread_csr and vwrite_csr to
riscv_vector.h (authored by pcwang-thead).
Repository:
rG LLVM Github Monorepo
CHANGES
pcwang-thead updated this revision to Diff 436344.
pcwang-thead added a comment.
Add `REQUIRES` to tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125875/new/
https://reviews.llvm.org/D125875
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rGaebe24a856d2: [RISCV] Add vread_csr and vwrite_csr to
riscv_vector.h (authored by pcwang-thead).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125875/new/
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125875/new/
https://reviews.llvm.org/D125875
pcwang-thead added a comment.
Ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125875/new/
https://reviews.llvm.org/D125875
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pcwang-thead added a comment.
Gentle ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125875/new/
https://reviews.llvm.org/D125875
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pcwang-thead updated this revision to Diff 431654.
pcwang-thead added a comment.
- Rebase.
- move tests to `test/CodeGen/RISCV/rvv-intrinsics`.
- Update functions' attrs.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125875/new/
khchen added a comment.
please move those tests to `test/CodeGen/RISCV/rvv-intrinsics` and rename them
without `rvv-` prefix.
Comment at: clang/include/clang/Basic/riscv_vector.td:1511
+__extension__ extern __inline
+__attribute__ ((__always_inline__, __gnu_inline__,
pcwang-thead updated this revision to Diff 430567.
pcwang-thead added a comment.
Add double underscore to all variables.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125875/new/
https://reviews.llvm.org/D125875
Files:
pcwang-thead added inline comments.
Comment at: clang/include/clang/Basic/riscv_vector.td:1512
+__attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
+unsigned long vread_csr(enum RVV_CSR csr) {
+ unsigned long rv = 0;
craig.topper wrote:
>
craig.topper added inline comments.
Comment at: clang/include/clang/Basic/riscv_vector.td:1512
+__attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
+unsigned long vread_csr(enum RVV_CSR csr) {
+ unsigned long rv = 0;
pcwang-thead wrote:
>
pcwang-thead added inline comments.
Comment at: clang/include/clang/Basic/riscv_vector.td:1511
+__extension__ extern __inline
+__attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
+unsigned long vread_csr(enum RVV_CSR csr) {
craig.topper wrote:
>
craig.topper added inline comments.
Comment at: clang/include/clang/Basic/riscv_vector.td:1511
+__extension__ extern __inline
+__attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
+unsigned long vread_csr(enum RVV_CSR csr) {
Do we need
pcwang-thead created this revision.
pcwang-thead added reviewers: asb, luismarques, kito-cheng, craig.topper.
Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr,
frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl,
jocewei, PkmX, the_o, brucehoult,
14 matches
Mail list logo
