[PATCH] D125892: [analyzer] Implement assumeInclusiveRange in terms of assumeInclusiveRangeDual

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32f189b0d9a8: [analyzer] Implement assumeInclusiveRange in terms of assumeInclusiveRangeDual (authored by martong). Repository: rG LLVM Github

[PATCH] D125892: [analyzer] Implement assumeInclusiveRange in terms of assumeInclusiveRangeDual

martong added a comment. In D125892#3524453 , @steakhal wrote: > Now I see, the summary confused me. > >> This includes the refactoring of the common assumle*Dual logic into the >> function template assumeDualImpl. > > I felt like this is a refactoring

[PATCH] D125892: [analyzer] Implement assumeInclusiveRange in terms of assumeInclusiveRangeDual

martong updated this revision to Diff 430637. martong marked an inline comment as done. martong edited the summary of this revision. martong added a comment. - Move SimpleConstraintManager's assume*Internal functions to be protected Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D125892: [analyzer] Implement assumeInclusiveRange in terms of assumeInclusiveRangeDual

steakhal added a comment. Now I see, the summary confused me. > This includes the refactoring of the common assumle*Dual logic into the > function template assumeDualImpl. I felt like this is a refactoring change, but it was not. It's about fixing the behavior by using the

[PATCH] D125892: [analyzer] Implement assumeInclusiveRange in terms of assumeInclusiveRangeDual

martong updated this revision to Diff 430611. martong added a comment. - Split into two patches, this first patch will be just the no-brainer copy-paste from assumeDual implementaton. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125892/new/

[PATCH] D125892: [analyzer] Implement assumeInclusiveRange in terms of assumeInclusiveRangeDual

martong added a comment. In D125892#3523296 , @steakhal wrote: > Okay, it took me a while to get what's going on. > Do you have anything in mind to express it by slightly less indirection, > references, templates and well, virtual functions xD Okay, I

[PATCH] D125892: [analyzer] Implement assumeInclusiveRange in terms of assumeInclusiveRangeDual

steakhal added a comment. Okay, it took me a while to get what's going on. Do you have anything in mind to express it by slightly less indirection, references, templates and well, virtual functions xD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125892: [analyzer] Implement assumeInclusiveRange in terms of assumeInclusiveRangeDual

martong created this revision. martong added reviewers: steakhal, NoQ. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a