[PATCH] D126093: Sema: adjust assertion to account for deduced types

2022-05-24 Thread Saleem Abdulrasool via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. compnerd marked an inline comment as done. Closed by commit rGb159108bc5eb: Sema: adjust assertion to account for deduced types (authored by compnerd). Changed prior to commit:

[PATCH] D126093: Sema: adjust assertion to account for deduced types

2022-05-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a testing request and a nit. Thanks for the fix! Comment at: clang/include/clang/Sema/DeclSpec.h:520 +assert(isDeclRep((TST)TypeSpecType) || isTypeRep((TST)TypeSpecType) || +

[PATCH] D126093: Sema: adjust assertion to account for deduced types

2022-05-24 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song accepted this revision. yonghong-song added a comment. This revision is now accepted and ready to land. Sorry. I missed this patch somehow and did another patch https://reviews.llvm.org/D126223. My patch skipped `TL.setNameLoc(DS.getTypeSpecTypeNameLoc());` which probably not

[PATCH] D126093: Sema: adjust assertion to account for deduced types

2022-05-20 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd updated this revision to Diff 431084. compnerd added a comment. git-clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126093/new/ https://reviews.llvm.org/D126093 Files: clang/include/clang/Sema/DeclSpec.h clang/test/Sema/typerep-typespec.c Index:

[PATCH] D126093: Sema: adjust assertion to account for deduced types

2022-05-20 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd created this revision. compnerd added a reviewer: aaron.ballman. compnerd added a project: clang. Herald added a project: All. compnerd requested review of this revision. Previous changes for the BTF attributes introduced a new sub-tree visitation. That uncovered that when accessing the