[PATCH] D126123: [analyzer][NFC] MemRegion::getRegion() never returns null

2022-05-24 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. In D126123#3531150 , @steakhal wrote: > In D126123#3531112 , @martong wrote: > >> Is it documented with `getRegion`? Could we decorate that with >> `returns-nonnull` >>

[PATCH] D126123: [analyzer][NFC] MemRegion::getRegion() never returns null

2022-05-23 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. In D126123#3531112 , @martong wrote: > Is it documented with `getRegion`? Could we decorate that with > `returns-nonnull` > https://clang.llvm.org/docs/AttributeReference.html#returns-nonnull ? Ah, I thought one of my

[PATCH] D126123: [analyzer][NFC] MemRegion::getRegion() never returns null

2022-05-23 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. Is it documented with `getRegion`? Could we decorate that with `returns-nonnull` https://clang.llvm.org/docs/AttributeReference.html#returns-nonnull ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126123/new/

[PATCH] D126123: [analyzer][NFC] MemRegion::getRegion() never returns null

2022-05-22 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. Until this point, the runtime and reports of the Clang Static Analyzer did not change on our testset; which confirms that the stack is indeed NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126123/new/

[PATCH] D126123: [analyzer][NFC] MemRegion::getRegion() never returns null

2022-05-21 Thread Balázs Benics via Phabricator via cfe-commits
steakhal updated this revision to Diff 431168. steakhal added reviewers: NoQ, martong. steakhal added a comment. Herald added a subscriber: rnkovacs. Well, my first use of arc went a bit sideways, so I'm falling back to posting this NFC patch batch manually. We will see how using arc works out

[PATCH] D126123: [analyzer][NFC] MemRegion::getRegion() never returns null

2022-05-21 Thread Balázs Benics via Phabricator via cfe-commits
steakhal updated this revision to Diff 431155. steakhal added a comment. `arc` used the HEAD^ as base, so I'm setting the parent patches now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126123/new/ https://reviews.llvm.org/D126123 Files:

[PATCH] D126123: [analyzer][NFC] MemRegion::getRegion() never returns null

2022-05-21 Thread Balázs Benics via Phabricator via cfe-commits
steakhal created this revision. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All. steakhal requested review of this revision.