[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

uabelho added a comment. @steakhal : Thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126198/new/ https://reviews.llvm.org/D126198 ___ cfe-commits mailing list

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

uabelho added a comment. In D126198#3549790 , @uabelho wrote: > Hi, > > I see crashes like this with this patch: > > clang: > ../../clang/include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:94: >

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

uabelho added a comment. Hi, I see crashes like this with this patch: clang: ../../clang/include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:94: clang::ento::PointerToMemberData::PointerToMemberData(const clang::NamedDecl *, llvm::ImmutableList): Assertion `D' failed.

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

steakhal added a comment. A sanitizer buildbot caught a wrong annotation, fixed by e651ed8621c3719937517ddb0b0815b18ec888e4 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGf13050eca356: [analyzer][NFCi] Annotate major nonnull returning functions (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D126198?vs=431379=432498#toc Repository: rG LLVM

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

steakhal updated this revision to Diff 431379. steakhal marked an inline comment as done. steakhal added a comment. `assert(ctx)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126198/new/ https://reviews.llvm.org/D126198 Files:

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

xazax.hun added a comment. I prefer references to annotations, but this is also a step in the right direction :l Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126198/new/ https://reviews.llvm.org/D126198

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

steakhal added inline comments. Comment at: clang/include/clang/Analysis/AnalysisDeclContext.h:233 + : Kind(k), Ctx(ctx), Parent(parent), ID(ID) { +assert(Ctx); + } martong wrote: > To be consistent with the other hunks, where you assert on the

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Looks good, with minor revisions. Comment at: clang/include/clang/Analysis/AnalysisDeclContext.h:233 + : Kind(k), Ctx(ctx), Parent(parent), ID(ID) { +assert(Ctx);

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

steakhal updated this revision to Diff 431343. steakhal added a comment. fix typo `migth` -> `might` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126198/new/ https://reviews.llvm.org/D126198 Files:

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

steakhal created this revision. steakhal added reviewers: NoQ, martong, Szelethus. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. steakhal requested review of this