[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGffe7950ebc62: Reland [analyzer] Deprecate `-analyzer-store

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

thakis added a comment. (As long as this builds and passes tests, I don't have an opinion on this change.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126215/new/ https://reviews.llvm.org/D126215 ___

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

steakhal updated this revision to Diff 436124. steakhal added a comment. - Add the new `diag::warn_analyzer_deprecated_option` warning to the `"deprecated-static-analyzer-flag"` `DiagGroup` to prevent breaking the `clang/test/Misc/warning-flags.c` test file. I'm also adding @thakis to review

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

steakhal added a comment. In D126215#3572984 , @thakis wrote: > Looks like this breaks building clang-tidy: > http://45.33.8.238/linux/78232/step_4.txt > > Please take a look, and revert for now if it takes a while to fix. Thanks. It should be fixed by

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

thakis added a comment. Looks like this breaks building clang-tidy: http://45.33.8.238/linux/78232/step_4.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126215/new/

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd50d9946d1d7: [analyzer] Deprecate `-analyzer-store region` flag (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

martong added a comment. In D126215#3565572 , @steakhal wrote: > I believe, the silence from the code owner means that he agrees with this > change. > I'll land it tomorrow. I believe there is a misconception about the role of a code owner, we cannot

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

steakhal added a comment. I believe, the silence from the code owner means that he agrees with this change. I'll land it tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126215/new/ https://reviews.llvm.org/D126215

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

martong accepted this revision. martong added a comment. Still looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126215/new/ https://reviews.llvm.org/D126215 ___ cfe-commits mailing list

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

steakhal updated this revision to Diff 432509. steakhal edited the summary of this revision. steakhal added a comment. - Specify exactly that we propose one release deprecation, then removal. - Test the help message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126215/new/ https://reviews.llvm.org/D126215

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

steakhal added a comment. @NoQ, please have a look at this. Comment at: clang/test/Analysis/deprecated-flags-and-options.cpp:1-13 +// RUN: %clang_analyze_cc1 -analyzer-checker=core %s 2>&1 \ +// RUN: | FileCheck %s --check-prefixes=CHECK + +// RUN: %clang_analyze_cc1

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

steakhal updated this revision to Diff 431618. steakhal edited the summary of this revision. steakhal added a comment. Herald added a subscriber: MaskRay. - Emit a warning when passing this option. - State explicitly in the release notes that passing this option to `clang-17` and above will

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

steakhal planned changes to this revision. steakhal added a comment. In D126215#3531780 , @martong wrote: >> We should support deprecated analyzer flags for at least one release. In >> this case I'm planning to drop this flag in clang-17 > > Should we

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

martong added a comment. > We should support deprecated analyzer flags for at least one release. In this > case I'm planning to drop this flag in clang-17 Should we emit a warning for the user about the deprecation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

steakhal created this revision. steakhal added reviewers: NoQ, martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All.