amyk added inline comments.
Comment at: clang/lib/Basic/Targets/PPC.cpp:452
+ if (llvm::is_contained(FeaturesVec, "-hard-float") &&
+ llvm::is_contained(FeaturesVec, "+altivec"))
+Diags.Report(diag::err_opt_not_valid_with_opt) << "-msoft-float"
Do we
qiucf added inline comments.
Comment at: clang/lib/Basic/Targets/PPC.cpp:450
+ // Cannot allow VSX with no Altivec.
+ if (llvm::is_contained(FeaturesVec, "-hard-float") &&
Comments in reverse order?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
ltertan added inline comments.
Comment at: clang/lib/Basic/Targets/PPC.cpp:455
+ << "-maltivec";
+
+ // Cannot allow soft-float with Altivec.
Do we also need to return from here?
Comment at:
Laurentiu added a comment.
Hi Nemanja,
I just realized I only had a personal account on llvm.org. Would you be
able to remove me from that review and add laurentiu.ter...@windriver.com
instead?
Thanks,
Laurentiu
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
nemanjai created this revision.
nemanjai added reviewers: Laurentiu, PowerPC.
Herald added subscribers: shchenz, kbarton.
Herald added a project: All.
nemanjai requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The current behaviour with
