martong added inline comments.
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:118
+ // Make internal constraint solver entities friends so they can access the
+ // overconstrained related functions. We want to keep this API inaccessible
+ //
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
martong marked an inline comment as done.
Closed by commit rGca3d962548b9: [analyzer] Return from reAssume if State is
posteriorly overconstrained (authored by
steakhal accepted this revision.
steakhal added a comment.
This revision is now accepted and ready to land.
Typo; other than that LGTM
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:118
+ // Make internal constraint solver entities friends
martong added inline comments.
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:127
+
+public:
bool isPosteriorlyOverconstrained() const {
steakhal wrote:
> This shouldnt be the way.
> Consider fwd declaring and making it
martong updated this revision to Diff 432225.
martong marked 5 inline comments as done.
martong added a comment.
- Make reAssume friend, pin the target in the test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126406/new/
steakhal added a comment.
Thanks for the quick response!
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:127
+
+public:
bool isPosteriorlyOverconstrained() const {
This shouldnt be the way.
Consider fwd declaring and making
martong added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2547
if (Constraint->encodesFalseRange())
return State->assume(DefinedVal, false);
I am wondering, that maybe it would be better to check for
martong created this revision.
martong added reviewers: NoQ, steakhal.
Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy,
Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware,
xazax.hun.
Herald added a reviewer: Szelethus.
Herald added a
