[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

nlopes added a comment. In D126745#3693790 , @khchen wrote: > @nlopes we will update all undef to poison in follow up patches. Thank you! The benefit is that we want to remove undef altogether, so I'm trying to avoid having more undefs introduced, and

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7eddeb9e99f3: [RISCV][Clang] Support policy functions for vmerge, vfmerge and (authored by khchen). Changed prior to commit:

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

khchen added a comment. @nlopes we will update all undef to poison in follow up patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126745/new/ https://reviews.llvm.org/D126745 ___ cfe-commits

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

khchen added a comment. oops.. all tests need to updated and include all intrinsic IR tests... Is there any benefit to switch UndefValue to PoisonValue? maybe those changed should be in other follow-up patches? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

khchen added a comment. In D126745#3691544 , @craig.topper wrote: > In D126745#3691528 , @khchen wrote: > >> In D126745#3678776 , @nlopes wrote: >> >>> While at it,

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

craig.topper added a comment. In D126745#3691528 , @khchen wrote: > In D126745#3678776 , @nlopes wrote: > >> While at it, could you switch those UndefValue with PoisonValue if possible? >> Thank you! > > I'm

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

khchen added a comment. In D126745#3678776 , @nlopes wrote: > While at it, could you switch those UndefValue with PoisonValue if possible? > Thank you! I'm not sure UndefValue will work because the backend would only check isUndef() to generate

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

nlopes added a comment. While at it, could you switch those UndefValue with PoisonValue if possible? Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126745/new/ https://reviews.llvm.org/D126745

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: nlopes. LGTM, and verified with internal testsuite :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, kito-cheng, fakepaper56, eopXD. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,