JDevlieghere requested changes to this revision.
JDevlieghere added a comment.
This revision now requires changes to proceed.
+1 on breaking this down per sub-project and creating separate patches for
review.
I sampled the patch and about a quarter or so of the links I tried didn't work,
even before the change. There's no point in generating churn by changing those,
but there's also little value in keeping them around, and fixing them is beyond
the scope of this patch. I'm inclined to say let's leave them be, but I'm
curious to hear what others think about that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127684/new/
https://reviews.llvm.org/D127684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits