[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

bryanpkc updated this revision to Diff 481205. bryanpkc added a comment. Removed some more unnecessary lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910 Files:

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

bryanpkc updated this revision to Diff 481137. bryanpkc added a comment. Removed some diffs that weren't necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910 Files:

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

bryanpkc marked 2 inline comments as done. bryanpkc added a comment. @david-arm, I have moved all the SME definitions into a new file, arm_sme.td. I have moved the common definitions into another file, arm_sve_sme_incl.td, which will be included by both arm_sve.td and arm_sme.td. SveEmitter has

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

bryanpkc updated this revision to Diff 481132. bryanpkc marked 5 inline comments as done. bryanpkc edited the summary of this revision. bryanpkc added a comment. Herald added a subscriber: mgrang. Herald added a reviewer: aaron.ballman. Updated the patch according to review comments which suggest

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

bryanpkc commandeered this revision. bryanpkc added a reviewer: sagarkulkarni19. bryanpkc added a comment. In D127910#3885699 , @david-arm wrote: > Hi @sagarkulkarni19, just a gentle ping to see if you are still planning to > do more work on this patch?

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

david-arm added a comment. Hi @sagarkulkarni19, just a gentle ping to see if you are still planning to do more work on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

david-arm added a comment. Hi @sagarkulkarni19, thank you for working on the ACLE builtins for SME! I've had a look through and I have a few comments, mostly around how the code is structured. It would be good if you could try to separate SVE from SME in this implementation, in the same way

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

sagarkulkarni19 updated this revision to Diff 463023. sagarkulkarni19 added a comment. Update testcases by adding "arm_streaming" attribute to the callee. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

sagarkulkarni19 updated this revision to Diff 459803. sagarkulkarni19 added a comment. - Support Opaque pointers - Correct predicate types for the intrinsics. - Decorate intrinsics with SME attributes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

sagarkulkarni19 marked 2 inline comments as done. sagarkulkarni19 added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:342 + if (HasSME) +Builder.defineMacro("__ARM_FEATURE_SME", "1"); + sdesmalen wrote: > sagarkulkarni19 wrote: > >

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

sagarkulkarni19 updated this revision to Diff 439919. sagarkulkarni19 edited the summary of this revision. sagarkulkarni19 added a comment. Updated testcases and also added the `vnum` variant of the ld1 and st1 intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

sdesmalen added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:342 + if (HasSME) +Builder.defineMacro("__ARM_FEATURE_SME", "1"); + sagarkulkarni19 wrote: > sdesmalen wrote: > > When this macro is non-zero, it suggests that the compiler

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

sagarkulkarni19 added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:209 def IsTupleSet: FlagType<0x4>; +def IsSME : FlagType<0x8>; +def IsSMELoadStore: FlagType<0x10>;

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

sagarkulkarni19 added a comment. In D127910#3589068 , @sdesmalen wrote: > Hi @sagarkulkarni19, this patch will have to wait until the ABI is > implemented so that the builtins can be decorated with the attributes. A > first patch proposing these

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

sdesmalen added a comment. Hi @sagarkulkarni19, this patch will have to wait until the ABI is implemented so that the builtins can be decorated with the attributes. A first patch proposing these attributes is in D127762 . LLVM patches that use these attributes