[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

mizvekov marked 2 inline comments as done. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:860 +} else if (const auto *ND = Unexpanded[I].first.get(); + isa(ND)) { + // Function parameter pack or init-capture pack.

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a0309c53674: [clang] Improve diagnostics for expansion length mismatch (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128095/new/

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Happy enough, LGTM. Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:860 +} else if (const auto *ND = Unexpanded[I].first.get(); + isa(ND)) { +

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:860 +} else if (const auto *ND = Unexpanded[I].first.get(); + isa(ND)) { + // Function parameter pack or init-capture pack. mizvekov wrote: > erichkeane

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

mizvekov updated this revision to Diff 456682. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128095/new/ https://reviews.llvm.org/D128095 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:860 +} else if (const auto *ND = Unexpanded[I].first.get(); + isa(ND)) { + // Function parameter pack or init-capture pack. erichkeane wrote: > This

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:860 +} else if (const auto *ND = Unexpanded[I].first.get(); + isa(ND)) { + // Function parameter pack or init-capture pack. This pattern with the init +

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

mizvekov retitled this revision from "WIP: [clang] Improve diagnostics for expansion length mismatch" to "[clang] Improve diagnostics for expansion length mismatch". mizvekov updated this revision to Diff 456495. mizvekov marked 5 inline comments as done. mizvekov requested review of this

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:103-106 +VisitSubstNonTypeTemplateParmPackExpr(SubstNonTypeTemplateParmPackExpr *E) { + Unexpanded.push_back({E, E->getParameterPackLocation()}); + return true; +}

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

erichkeane added a comment. just a pair of minor changes I'd like to see, otherwise this LGTM. Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:103-106 +VisitSubstNonTypeTemplateParmPackExpr(SubstNonTypeTemplateParmPackExpr *E) { + Unexpanded.push_back({E,

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:103-106 +VisitSubstNonTypeTemplateParmPackExpr(SubstNonTypeTemplateParmPackExpr *E) { + Unexpanded.push_back({E, E->getParameterPackLocation()}); + return true; +}

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:103-106 +VisitSubstNonTypeTemplateParmPackExpr(SubstNonTypeTemplateParmPackExpr *E) { + Unexpanded.push_back({E, E->getParameterPackLocation()}); + return true; +}

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

mizvekov added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128095/new/ https://reviews.llvm.org/D128095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

mizvekov updated this revision to Diff 453757. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128095/new/ https://reviews.llvm.org/D128095 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:746 unsigned Depth, Index; -std::tie(Depth, Index) = getDepthAndIndex(Unexpanded[I]); +std::tie(Depth, Index) = getDepthAndIndex(U); if (Depth ==

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

shafik added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:746 unsigned Depth, Index; -std::tie(Depth, Index) = getDepthAndIndex(Unexpanded[I]); +std::tie(Depth, Index) = getDepthAndIndex(U); if (Depth ==

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 452693. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128095/new/ https://reviews.llvm.org/D128095 Files: clang/docs/ReleaseNotes.rst

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

mizvekov added a comment. In D128095#3712343 , @erichkeane wrote: > Can you make a better commit message? I don't have a good idea of the > intent/description of what you're trying to do here. Done. I split this up into two patches: - D131802

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

mizvekov retitled this revision from "clang: fix checking parameter packs for expansion" to "[clang] Improve diagnostics for expansion length mismatch". mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 452306. Repository: rG LLVM Github Monorepo CHANGES