This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1e308204838b: [WinEH] Apply funclet operand bundles to
nounwind intrinsics that lower to… (authored by sgraenitz).
Repository:
rG LLVM Github
sgraenitz added a comment.
Pre-merge checks passed on Windows. Debian failures are unrelated. Locally on
Ubuntu and macOS all tests pass. Getting ready to land this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128190/new/
sgraenitz added a comment.
Hi @theraven thanks for reviewing!
Comment at: llvm/lib/IR/IntrinsicInst.cpp:61
+ case Intrinsic::objc_sync_enter:
+ case Intrinsic::objc_sync_exit:
+return true;
theraven wrote:
> I'm curious why memcpy and friends don't need
sgraenitz updated this revision to Diff 447667.
sgraenitz marked 2 inline comments as done.
sgraenitz added a comment.
Rebase and polish comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128190/new/
https://reviews.llvm.org/D128190
Files:
theraven accepted this revision.
theraven added a comment.
This revision is now accepted and ready to land.
LGTM, a couple of extra comments would help.
Comment at: llvm/include/llvm/IR/IntrinsicInst.h:110
+ // Check if this intrinsic might lower into a regular function
sgraenitz added a comment.
Running `check-llvm` and `check-clang` locally found no more failing tests. The
issue is not limited to pre-ISel intrinsics (anymore) and I have to re-phrase a
few comments. Apart from that, is there any more feedback? Thanks
Repository:
rG LLVM Github Monorepo
sgraenitz updated this revision to Diff 438425.
sgraenitz added a comment.
Add missing `objc_sync_exit` to fix failing test
Transforms/PreISelIntrinsicLowering/objc-arc.ll
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128190/new/
sgraenitz created this revision.
sgraenitz added reviewers: rnk, theraven, DHowett-MSFT.
Herald added subscribers: jsji, pengfei, hiraditya.
Herald added a project: All.
sgraenitz requested review of this revision.
Herald added projects: clang, LLVM.
Herald added a subscriber: cfe-commits.
