This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rG312116748890: [pseudo] Add error-recovery framework
brace-based recovery (authored by sammccall).
sammccall marked 5 inline comments as done.
sammccall added a comment.
Thanks in particular for flagging the issue with duplicate forest nodes, you've
found a hole in the model.
That said, I've left a big FIXME and I think we should patch it later.
Comment at:
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Looks great, let's ship it! feel free to land it in any form you think it is
suitable.
Comment at: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h:150
+// OldHeads is
sammccall added inline comments.
Comment at: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h:150
+// OldHeads is the parse state at TokenIndex.
+// This function consumes consumes zero or more tokens (advancing TokenIndex),
+// and places any recovery states created in
sammccall updated this revision to Diff 441154.
sammccall added a comment.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128486/new/
https://reviews.llvm.org/D128486
Files:
clang-tools-extra/pseudo/include/clang-pseudo/GLR.h
sammccall updated this revision to Diff 441125.
sammccall marked 14 inline comments as done.
sammccall added a comment.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128486/new/
https://reviews.llvm.org/D128486
Files:
hokein added a comment.
the patch looks a good start to me, some initial comments (mostly around the
recovery part).
Comment at: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h:150
+// OldHeads is the parse state at TokenIndex.
+// This function consumes consumes zero or
sammccall reopened this revision.
sammccall added a comment.
Sorry, I committed this by mistake when working on another change.
Reverted and this is ready for review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128486/new/
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa0f4c10ae227: [pseudo] Add error-recovery framework
brace-based
sammccall updated this revision to Diff 440646.
sammccall added a comment.
rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128486/new/
https://reviews.llvm.org/D128486
Files:
clang-tools-extra/pseudo/include/clang-pseudo/GLR.h
sammccall updated this revision to Diff 440393.
sammccall edited the summary of this revision.
sammccall added a comment.
update testcase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128486/new/
https://reviews.llvm.org/D128486
Files:
sammccall updated this revision to Diff 440383.
sammccall added a comment.
revert format changes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128486/new/
https://reviews.llvm.org/D128486
Files:
sammccall created this revision.
Herald added a subscriber: mgrang.
Herald added a project: All.
sammccall updated this revision to Diff 440376.
sammccall retitled this revision from "xxx recover" to "[pseudo] Add
error-recovery framework & brace-based recovery".
sammccall edited the summary of
13 matches
Mail list logo
