[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

sdesmalen accepted this revision. sdesmalen added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128648/new/ https://reviews.llvm.org/D128648 ___ cfe-commits mailing list

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

bryanpkc marked an inline comment as done. bryanpkc added inline comments. Comment at: clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_read.c:22 +// +svint8_t test_svread_hor_za8_s8(svint8_t zd, svbool_t pg, uint32_t slice_base) __arm_streaming { +return

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

sdesmalen accepted this revision. sdesmalen added a comment. Patch LGTM, thanks. Just a note that you'll need to remove the trailing `__arm_streaming` attribute from `acle_sme_read.c` in order to be able to land the patch without causing test failures. Comment at:

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

bryanpkc marked an inline comment as done. bryanpkc added inline comments. Comment at: clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_read.c:13 +#else +#define ARM_STREAMING_ATTR __attribute__((arm_streaming)) +#endif sdesmalen wrote: > The spelling has

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

sdesmalen added inline comments. Comment at: clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_read.c:13 +#else +#define ARM_STREAMING_ATTR __attribute__((arm_streaming)) +#endif The spelling has recently changed to the `__arm_streaming`. Also with the new

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

bryanpkc added a comment. @sdesmalen Could you take a look at the patch stack again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128648/new/ https://reviews.llvm.org/D128648 ___ cfe-commits mailing

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

sdesmalen added a comment. Other than the two nits, the patch looks good. Thanks. Comment at: clang/include/clang/Basic/arm_sme.td:82 +def NAME # _H : SInst<"svread_hor_" # n_suffix # "[_{d}]", "ddPimi", t, MergeOp1, + "aarch64_sme_read" #

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

bryanpkc added a comment. @sdesmalen Could you review this and the rest of the patch stack? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128648/new/ https://reviews.llvm.org/D128648 ___ cfe-commits

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

bryanpkc added a comment. Rebased on main, and removed dependence on the SME attributes patch as per https://reviews.llvm.org/D127910?vs=522039=522064#inline-1451681. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128648/new/

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

kmclaughlin accepted this revision. kmclaughlin added a comment. This revision is now accepted and ready to land. Thank you @bryanpkc, this LGTM Comment at: clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_read.c:2 +// REQUIRES: aarch64-registered-target +// RUN: %clang_cc1

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

bryanpkc added inline comments. Comment at: clang/include/clang/Basic/arm_sme.td:103 +def NAME # _H : SInst<"svwrite_hor_" # n_suffix # "[_{d}]", "vimiPd", t, MergeOp1, + "aarch64_sme_write" # !cond(!eq(n_suffix, "za128") : "q", true: "") #

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

kmclaughlin added a comment. Hi @bryanpkc, thank you for updating this patch & applying the previous review comments here too. I just have a couple of minor suggestions: Comment at: clang/include/clang/Basic/arm_sme.td:103 +def NAME # _H : SInst<"svwrite_hor_" # n_suffix