[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2b158e29eed: clang/cmake: Drop use of llvm-config for LLVM install discovery (authored by tstellar, committed by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

mgorny accepted this revision. mgorny added a comment. This one LGTM to me as well, and doesn't seem to break Gentoo either ;-). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128777/new/ https://reviews.llvm.org/D128777

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

Ericson2314 updated this revision to Diff 450529. Ericson2314 added a comment. Add my changes but split to just Clang as @tstellar requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128777/new/ https://reviews.llvm.org/D128777 Files:

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

tstellar added a comment. @Ericson2314 Your version of these patches removed a few more things than mine (which seems better to me), do you want to just split your patch and commit the parts separately? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. This is similar to @Ericson2314's change D130735 which also removes `llvm-config` from LLD. I'm fine with either of the two changes. It might be better to

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

tstellar added inline comments. Comment at: clang/CMakeLists.txt:21-23 + set(INCLUDE_DIRS "${LLVM_BINARY_DIR}/include" "${MAIN_INCLUDE_DIR}") + # Pull values from LLVMConfig.cmake. + set(MAIN_INCLUDE_DIR "${LLVM_INCLUDE_DIR}") tstellar wrote: > This doesn't

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

tstellar updated this revision to Diff 449857. tstellar added a comment. Remove more of the existing code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128777/new/ https://reviews.llvm.org/D128777 Files: clang/CMakeLists.txt Index:

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

tstellar added inline comments. Comment at: clang/CMakeLists.txt:21-23 + set(INCLUDE_DIRS "${LLVM_BINARY_DIR}/include" "${MAIN_INCLUDE_DIR}") + # Pull values from LLVMConfig.cmake. + set(MAIN_INCLUDE_DIR "${LLVM_INCLUDE_DIR}") This doesn't look right (even

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

tstellar updated this revision to Diff 449783. tstellar added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128777/new/ https://reviews.llvm.org/D128777 Files: clang/CMakeLists.txt Index: clang/CMakeLists.txt

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

tstellar created this revision. Herald added a subscriber: mgorny. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This has been deprecated for a while, remove it in favor of using cmake's