This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0880b9d52620: [Clang][unittests] Silence trucation warning
with MSVC 2022 (authored by aganea).
Repository:
rG LLVM Github Monorepo
CHANGES
aganea added a comment.
Thanks all for reviewing!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129152/new/
https://reviews.llvm.org/D129152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
thieta accepted this revision.
thieta added a comment.
Thanks for switching to pragma!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129152/new/
https://reviews.llvm.org/D129152
___
cfe-commits mailing
ASDenysPetrov accepted this revision.
ASDenysPetrov added a comment.
This revision is now accepted and ready to land.
@aganea Thank you for fixing this.
`TestValues` structure impies to hold a set of values which can do some kind of
convertions including truncations. This is what tests are
aganea updated this revision to Diff 442366.
aganea added a comment.
Use `#pragma`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129152/new/
https://reviews.llvm.org/D129152
Files:
clang/unittests/StaticAnalyzer/RangeSetTest.cpp
Index:
thieta added a comment.
Isn't it better to silence this warning with a pragma instead of disabling it
for the whole file?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129152/new/
https://reviews.llvm.org/D129152
aganea created this revision.
aganea added reviewers: ASDenysPetrov, thieta, hans.
Herald added subscribers: steakhal, mgorny.
Herald added a project: All.
aganea requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
I'm seeing the following
