This revision was automatically updated to reflect the committed changes.
tra marked an inline comment as done.
Closed by commit rL248299: [CUDA] Allow parsing of host and device code
simultaneously. (authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D12917?vs=35031=35389#toc
jpienaar added a comment.
Nice, so this will allow parsing/AST construction with builtins from 2
architectures but will fail to compile if a builtin for the host/device is
called from device/host.
You mention this is not generally possible. Can you give some examples?
tra updated this revision to Diff 35015.
tra marked an inline comment as done.
tra added a comment.
cosmetic fixes.
http://reviews.llvm.org/D12917
Files:
include/clang/AST/ASTContext.h
include/clang/Basic/Builtins.h
include/clang/Driver/CC1Options.td
tra marked an inline comment as done.
tra added a comment.
In http://reviews.llvm.org/D12917#247868, @jpienaar wrote:
> Nice, so this will allow parsing/AST construction with builtins from 2
> architectures but will fail to compile if a builtin for the host/device is
> called from device/host.
tra marked 2 inline comments as done.
Comment at: lib/Frontend/CompilerInstance.cpp:82-87
@@ -84,6 +81,8 @@
+void CompilerInstance::setTarget(TargetInfo *Value) { Target = Value; }
+void CompilerInstance::setAuxTarget(TargetInfo *Value) { AuxTarget = Value; }
void
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Works for me. Thanks!
-eric
http://reviews.llvm.org/D12917
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tra updated this revision to Diff 35031.
tra marked an inline comment as done.
tra added a comment.
Updated to address Eric's comments.
http://reviews.llvm.org/D12917
Files:
include/clang/AST/ASTContext.h
include/clang/Basic/Builtins.h
include/clang/Driver/CC1Options.td
echristo added a comment.
One inline request and one inline comment, otherwise looks pretty good!
Thanks :)
-eric
Comment at: include/clang/Frontend/CompilerInstance.h:355
@@ -350,3 +354,3 @@
- /// Replace the current diagnostics engine.
+ /// Replace the current Target.
tra created this revision.
tra added reviewers: echristo, eliben, jpienaar.
tra added a subscriber: cfe-commits.
Herald added subscribers: dschuff, jfb.
The patch:
- adds -aux-triple option to specify target triple
- propagates aux target info to AST context and Preprocessor
- pulls in
