[PATCH] D129476: [AArch64][SVE] Prefer SIMD variant of clast[ab]

2022-07-13 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes closed this revision. c-rhodes marked an inline comment as done. c-rhodes added a comment. In D129476#3645667 , @efriedma wrote: > Please update the comment, then LGTM Done, cheers Eli. CHANGES SINCE LAST ACTION

[PATCH] D129476: [AArch64][SVE] Prefer SIMD variant of clast[ab]

2022-07-12 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Please update the comment, then LGTM Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:801 +

[PATCH] D129476: [AArch64][SVE] Prefer SIMD variant of clast[ab]

2022-07-12 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes added a comment. In D129476#3643382 , @efriedma wrote: > Are you saying that it's faster to use clasta targeting a float register, > then move the result to an integer register, rather than use the integer form > directly? Or is the issue

[PATCH] D129476: [AArch64][SVE] Prefer SIMD variant of clast[ab]

2022-07-11 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Are you saying that it's faster to use clasta targeting a float register, then move the result to an integer register, rather than use the integer form directly? Or is the issue just that we want to split the operations in case we can simplify the resulting bitcast?

[PATCH] D129476: [AArch64][SVE] Prefer SIMD variant of clast[ab]

2022-07-11 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes updated this revision to Diff 443594. c-rhodes added a comment. Add full patch context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129476/new/ https://reviews.llvm.org/D129476 Files: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_clasta.c

[PATCH] D129476: [AArch64][SVE] Prefer SIMD variant of clast[ab]

2022-07-11 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes created this revision. c-rhodes added reviewers: paulwalker-arm, bsmith, peterwaller-arm, DavidTruby. Herald added subscribers: psnobl, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. c-rhodes requested review of this revision. Herald