This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf34ecb50e2c0: [clang] Dont emit type tests for
dllexport/import classes (authored by aeubanks).
Repository:
rG LLVM Github Monorepo
CHANGES
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129700/new/
https://reviews.llvm.org/D129700
___
aeubanks added a comment.
Herald added a subscriber: bd1976llvm.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129700/new/
https://reviews.llvm.org/D129700
___
cfe-commits mailing list
aeubanks updated this revision to Diff 500987.
aeubanks added a comment.
move HasHiddenLTOVisibility DLL code to AlwaysHasLTOVisibilityPublic
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129700/new/
https://reviews.llvm.org/D129700
Files:
pcc added a comment.
Can't the code in CodeGenModule::HasHiddenLTOVisibility be moved here instead
of duplicating it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129700/new/
https://reviews.llvm.org/D129700
aeubanks added a comment.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129700/new/
https://reviews.llvm.org/D129700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aeubanks added a comment.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129700/new/
https://reviews.llvm.org/D129700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aeubanks added a comment.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129700/new/
https://reviews.llvm.org/D129700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aeubanks created this revision.
aeubanks added reviewers: pcc, tejohnson.
Herald added subscribers: ormris, steven_wu, hiraditya.
Herald added a project: All.
aeubanks requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
According to