Re: [PATCH] D12989: [CUDA] Added CUDA installation detector class.

2015-09-23 Thread Artem Belevich via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248408: [CUDA] Added CUDA installation detector class. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D12989?vs=35531=35533#toc Repository: rL LLVM

Re: [PATCH] D12989: [CUDA] Added CUDA installation detector class.

2015-09-23 Thread NAKAMURA Takumi via cfe-commits
chapuni added a subscriber: chapuni. Comment at: cfe/trunk/lib/Driver/ToolChains.cpp:1492 @@ +1491,3 @@ +const llvm::opt::ArgList ) { + SmallVector CudaPathCandidates; + Fixed in r248459.

Re: [PATCH] D12989: [CUDA] Added CUDA installation detector class.

2015-09-23 Thread Eric Christopher via cfe-commits
echristo added a subscriber: echristo. echristo added a comment. Aha, nice catch! -eric Repository: rL LLVM http://reviews.llvm.org/D12989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12989: [CUDA] Added CUDA installation detector class.

2015-09-23 Thread Eric Christopher via cfe-commits
Aha, nice catch! -eric On Wed, Sep 23, 2015 at 9:32 PM NAKAMURA Takumi wrote: > chapuni added a subscriber: chapuni. > > > Comment at: cfe/trunk/lib/Driver/ToolChains.cpp:1492 > @@ +1491,3 @@ > +const

Re: [PATCH] D12989: [CUDA] Added CUDA installation detector class.

2015-09-22 Thread Eric Christopher via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Thanks! -eric http://reviews.llvm.org/D12989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12989: [CUDA] Added CUDA installation detector class.

2015-09-21 Thread Artem Belevich via cfe-commits
tra updated the summary for this revision. tra updated this revision to Diff 35333. tra added a comment. Added test case for CUDA detection. Removed libdevice file detection for now. http://reviews.llvm.org/D12989 Files: include/clang/Driver/Options.td lib/Driver/ToolChains.cpp

Re: [PATCH] D12989: [CUDA] Added CUDA installation detector class.

2015-09-21 Thread Artem Belevich via cfe-commits
tra added a comment. I'll add tests for install dir detection. As for detection of bitcode files, perhaps I should remove it from this patch and commit it along with the code that's going to use it and where I can test it. http://reviews.llvm.org/D12989

Re: [PATCH] D12989: [CUDA] Added CUDA installation detector class.

2015-09-21 Thread Eric Christopher via cfe-commits
echristo added a comment. In http://reviews.llvm.org/D12989#250247, @tra wrote: > I'll add tests for install dir detection. As for detection of bitcode files, > perhaps I should remove it from this patch and commit it along with the code > that's going to use it and where I can test it.

Re: [PATCH] D12989: [CUDA] Added CUDA installation detector class.

2015-09-18 Thread Artem Belevich via cfe-commits
tra added a comment. Any suggestions how to test this? http://reviews.llvm.org/D12989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D12989: [CUDA] Added CUDA installation detector class.

2015-09-18 Thread Artem Belevich via cfe-commits
tra created this revision. tra added a reviewer: echristo. tra added a subscriber: cfe-commits. The class searches for a CUDA installation directory and provides accessors for relevant bits of info about it. Added new option --cuda-path= which allows overriding default search paths. If it's