[PATCH] D130123: Extend ptr32 support to be applied on typedef

This revision was automatically updated to reflect the committed changes. Closed by commit rGf53f2f232f79: Extend ptr32 support to be applied on typedef (authored by Ariel-Burton, committed by muiez). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130123: Extend ptr32 support to be applied on typedef

rnk accepted this revision. rnk added a comment. In D130123#3708309 , @Ariel-Burton wrote: > - Add case to deal with ElaboratedTypes. Let's still stick with this code, but I at least feel justified raising the concern that perhaps we should look

[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel-Burton updated this revision to Diff 450982. Ariel-Burton added a comment. - Add case to deal with ElaboratedTypes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130123/new/ https://reviews.llvm.org/D130123 Files:

[PATCH] D130123: Extend ptr32 support to be applied on typedef

rnk accepted this revision. rnk added a comment. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130123/new/ https://reviews.llvm.org/D130123 ___ cfe-commits mailing list

[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel-Burton added a comment. In D130123#3700174 , @rnk wrote: > In D130123#3698399 , @Ariel-Burton > wrote: > >> Just to make sure that we're on the same page, you'd like to see a test >> that confirms that

[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel-Burton updated this revision to Diff 450157. Ariel-Burton added a comment. Recover original changes, and commit with new C++ __ptr32 test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130123/new/ https://reviews.llvm.org/D130123 Files:

[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel-Burton updated this revision to Diff 450153. Ariel-Burton added a comment. Added C++ tests for __ptr32. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130123/new/ https://reviews.llvm.org/D130123 Files:

[PATCH] D130123: Extend ptr32 support to be applied on typedef

rnk added a comment. In D130123#3698399 , @Ariel-Burton wrote: > Just to make sure that we're on the same page, you'd like to see a test that > confirms that clang is rejecting the `template void f(T __ptr32 > a)` example, and possibly one that

[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel-Burton added a comment. In D130123#3696786 , @rnk wrote: > In D130123#3696752 , @Ariel-Burton > wrote: > >> What is your expectation for your template code fragment? MSVC does not >> accept it. > > Yes,

[PATCH] D130123: Extend ptr32 support to be applied on typedef

rnk added a comment. In D130123#3696752 , @Ariel-Burton wrote: > What is your expectation for your template code fragment? MSVC does not > accept it. Yes, I checked, MSVC rejects it, so clang should have test expectations to confirm that. It seems

[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel-Burton added a comment. In D130123#3691011 , @rnk wrote: > That sounds reasonable to me, I confirmed that MSVC really only lets you > apply these attributes directly to pointer types and to typedefs. > > Can you add a test for the other most

[PATCH] D130123: Extend ptr32 support to be applied on typedef

rnk added a comment. That sounds reasonable to me, I confirmed that MSVC really only lets you apply these attributes directly to pointer types and to typedefs. Can you add a test for the other most common type sugar node, the template parameter? It looks like this: template void f(T

[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel-Burton added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7116 + for (;;) { +if (const TypedefType *TT = dyn_cast(Desugared)) { + Desugared = TT->desugar(); rnk wrote: > Ariel-Burton wrote: > > rnk wrote: > > > This seems like a good

[PATCH] D130123: Extend ptr32 support to be applied on typedef

rnk added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7116 + for (;;) { +if (const TypedefType *TT = dyn_cast(Desugared)) { + Desugared = TT->desugar(); Ariel-Burton wrote: > rnk wrote: > > This seems like a good place to use

[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel-Burton added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7116 + for (;;) { +if (const TypedefType *TT = dyn_cast(Desugared)) { + Desugared = TT->desugar(); rnk wrote: > This seems like a good place to use getSingleStepDesugaredType

[PATCH] D130123: Extend ptr32 support to be applied on typedef

rnk added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7116 + for (;;) { +if (const TypedefType *TT = dyn_cast(Desugared)) { + Desugared = TT->desugar(); This seems like a good place to use getSingleStepDesugaredType to look through all