[PATCH] D130138: [modules] Replace `-Wauto-import` with `-Rmodule-include-translation`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG381fcaa1365b: [modules] Replace `-Wauto-import` with `-Rmodule-include-translation`. (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130138: [modules] Replace `-Wauto-import` with `-Rmodule-include-translation`.

vsapsai added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130138/new/ https://reviews.llvm.org/D130138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D130138: [modules] Replace `-Wauto-import` with `-Rmodule-include-translation`.

iains accepted this revision. iains added a comment. This revision is now accepted and ready to land. In D130138#3667172 , @MaskRay wrote: > In D130138#3664913 , @iains wrote: > >> makes sense to me... >> >> I

[PATCH] D130138: [modules] Replace `-Wauto-import` with `-Rmodule-include-translation`.

MaskRay added a comment. In D130138#3664913 , @iains wrote: > makes sense to me... > > I guess the name looks long at first, but it's specific (I find that > easy-to-remember flag names are more important than short-to-type ones, but > maybe that's

[PATCH] D130138: [modules] Replace `-Wauto-import` with `-Rmodule-include-translation`.

vsapsai added a comment. Looks like GCC has some naming pattern there, thanks for sharing, Iain. So I want to share the pattern I'm aiming for. I'd like the flag to start with `-Rmodule-...` to be consistent with `-Rmodule-build`, `-Rmodule-import`, `-Rmodule-lock`. Repository: rG LLVM

[PATCH] D130138: [modules] Replace `-Wauto-import` with `-Rmodule-include-translation`.

iains added a subscriber: MaskRay. iains added a comment. makes sense to me... I guess the name looks long at first, but it's specific (I find that easy-to-remember flag names are more important than short-to-type ones, but maybe that's just me) - I wonder if @MaskRay has any comments on the

[PATCH] D130138: [modules] Replace `-Wauto-import` with `-Rmodule-include-translation`.

vsapsai added a comment. Not sure about the name of the flag `-Rmodule-include-translation`, seems to be verbose. So suggestions about the flag name are welcome. On the other hand, "auto-import" is expected to mean something else, for example, adding missing imports

[PATCH] D130138: [modules] Replace `-Wauto-import` with `-Rmodule-include-translation`.

vsapsai created this revision. vsapsai added reviewers: iains, rsmith, benlangmuir, arphaman. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Diagnostic for `-Wauto-import` shouldn't be a warning because