[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80a4e6fd31a0: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation (authored by MaskRay). Changed prior to commit:

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:146 +Arg *A; +if (getDebugFissionKind(D, Args, A) != DwarfFissionKind::None) + D.Diag(clang::diag::err_drv_riscv_unsupported_with_linker_relaxation) compnerd

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

compnerd added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:146 +Arg *A; +if (getDebugFissionKind(D, Args, A) != DwarfFissionKind::None) + D.Diag(clang::diag::err_drv_riscv_unsupported_with_linker_relaxation) MaskRay

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

kito-cheng accepted this revision. kito-cheng added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130190/new/ https://reviews.llvm.org/D130190 ___ cfe-commits mailing list

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:146 +Arg *A; +if (getDebugFissionKind(D, Args, A) != DwarfFissionKind::None) +

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

compnerd requested changes to this revision. compnerd added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:146 +Arg *A; +if (getDebugFissionKind(D, Args, A) != DwarfFissionKind::None) +

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:10 #include "RISCV.h" +#include "../Clang.h" #include "ToolChains/CommonArgs.h" compnerd wrote: > This feels like a layering violation. I suppose that as long as modular >

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

compnerd added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:10 #include "RISCV.h" +#include "../Clang.h" #include "ToolChains/CommonArgs.h" This feels like a layering violation. I suppose that as long as modular builds are okay ...

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

MaskRay updated this revision to Diff 446239. MaskRay added a comment. incompatible => unsupported since it is implementable (but difficult). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130190/new/ https://reviews.llvm.org/D130190 Files:

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

MaskRay created this revision. MaskRay added reviewers: compnerd, jrtc27, kito.cheng. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,