[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

daltenty added a comment. In D130327#3944591 , @vsapsai wrote: > In D130327#3944188 , @NancyWang > wrote: > >> @vsapsai hi Volodymyr Sapsai , test case >> clang/test/Modules/hidden-duplicates.m is failing

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

vsapsai added a comment. In D130327#3944188 , @NancyWang wrote: > @vsapsai hi Volodymyr Sapsai , test case > clang/test/Modules/hidden-duplicates.m is failing on our llvm community AIX > box >

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

NancyWang added a comment. @vsapsai hi Volodymyr Sapsai , test case clang/test/Modules/hidden-duplicates.m is failing on our llvm community AIX box https://lab.llvm.org/buildbot/#/builders/214/builds/4442/steps/6/logs/FAIL__Clang__hidden-duplicates_m , it gives exit code 70 without detail

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

vsapsai added a comment. Thanks for reviews! It was a long journey. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130327/new/ https://reviews.llvm.org/D130327 ___ cfe-commits mailing list

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa65d5309d5b7: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing. (authored by vsapsai). Repository: rG LLVM Github

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

bruno accepted this revision. bruno added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130327/new/ https://reviews.llvm.org/D130327 ___ cfe-commits mailing list

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. Although I'm not familiar with Objc, the change here looks good generally. Comment at: clang/include/clang/Sema/Sema.h:10091-10096 ObjCProtocolDecl

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130327/new/ https://reviews.llvm.org/D130327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

vsapsai updated this revision to Diff 469444. vsapsai added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130327/new/ https://reviews.llvm.org/D130327 Files: clang/include/clang/AST/DeclObjC.h

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

vsapsai updated this revision to Diff 465954. vsapsai added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130327/new/ https://reviews.llvm.org/D130327 Files: clang/include/clang/AST/DeclObjC.h

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

vsapsai created this revision. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When during parsing we encountered a duplicate `ObjCProtocolDecl`, we were always