[PATCH] D130372: [analyzer] Add a new factory function RangeSet::Factory::invert

ASDenysPetrov added a comment. The //motivation //for this revision is lost due to the logical mistake in the later. However, this revision could be used for other improvements in the future. I will not merge it until new //motivation //has become. CHANGES SINCE LAST ACTION

[PATCH] D130372: [analyzer] Add a new factory function RangeSet::Factory::invert

ASDenysPetrov added a comment. In D130372#3699036 , @martong wrote: > LGTM! Nice work! Thank you. I prefer to load this along with the motivation part D131006 . CHANGES SINCE LAST ACTION

[PATCH] D130372: [analyzer] Add a new factory function RangeSet::Factory::invert

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Nice work! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130372/new/ https://reviews.llvm.org/D130372 ___ cfe-commits mailing

[PATCH] D130372: [analyzer] Add a new factory function RangeSet::Factory::invert

ASDenysPetrov added inline comments. Comment at: clang/unittests/StaticAnalyzer/RangeSetTest.cpp:1130 + // Check inverting single range. + this->checkInvert({{MIN, MAX}}, {}); + this->checkInvert({{MIN, MID}}, {{MID + 1, MAX}}); martong wrote: > ASDenysPetrov

[PATCH] D130372: [analyzer] Add a new factory function RangeSet::Factory::invert

ASDenysPetrov added a comment. @martong > Now I'm working on the next patch and you'll see a motivation soon. Here is the motivation but it still causes some tests failure D131006 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130372/new/

[PATCH] D130372: [analyzer] Add a new factory function RangeSet::Factory::invert

martong added a comment. In D130372#3683275 , @ASDenysPetrov wrote: > Now I'm working on the next patch and you'll see a motivation soon. Thanks for the update! Looks good, but I am still waiting with my formal approve to understand the motivation.

[PATCH] D130372: [analyzer] Add a new factory function RangeSet::Factory::invert

ASDenysPetrov updated this revision to Diff 448161. ASDenysPetrov added a comment. Make changes according to the remarks. - Add complexity to function description. - Rewrite the loop making it deterministic. - Add back invert operation to the tests. CHANGES SINCE LAST ACTION

[PATCH] D130372: [analyzer] Add a new factory function RangeSet::Factory::invert

ASDenysPetrov marked 3 inline comments as done. ASDenysPetrov added a comment. Now I'm working on the next patch and you'll see a motivation soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130372/new/ https://reviews.llvm.org/D130372

[PATCH] D130372: [analyzer] Add a new factory function RangeSet::Factory::invert

ASDenysPetrov marked 6 inline comments as done. ASDenysPetrov added a comment. @martong Thanks for review. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:728-729 + ContainerType Result; + Result.reserve(What.size() + 1 - bool(What.getMinValue() != MIN)

[PATCH] D130372: [analyzer] Add a new factory function RangeSet::Factory::invert

martong added a comment. > The motivation is to extend the set of operations that can be performed on > range sets. Specifically, this function is needed for the next patch in the > stack. Would be great to see the motivation clearly and early. What will be the next patch about?

[PATCH] D130372: [analyzer] Add a new factory function RangeSet::Factory::invert

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: martong, NoQ, steakhal, balazske. ASDenysPetrov added a project: clang. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a